Re: [PATCH] dmaengine: hisilicon: Return -ENOMEM on dynamic memory allocation in probe

[Frank Li <Frank.li@oss.nxp.com>]

On Tue, Jun 30, 2026 at 05:42:14PM +0300, Vladimir Zapolskiy wrote:
>
> Out of memory situation on driver's probe is expected to be reported to
> the driver's framework with a proper -ENOMEM error code.
>
> Fixes: e9f08b65250d ("dmaengine: hisilicon: Add Kunpeng DMA engine support")
> Signed-off-by: Vladimir Zapolskiy <vz@kernel.org>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/hisi_dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/hisi_dma.c b/drivers/dma/hisi_dma.c
> index 28bf818f9aa6..c751a2e49e6d 100644
> --- a/drivers/dma/hisi_dma.c
> +++ b/drivers/dma/hisi_dma.c
> @@ -983,7 +983,7 @@ static int hisi_dma_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>         hdma_dev = devm_kzalloc(dev, struct_size(hdma_dev, chan, chan_num),
>                                 GFP_KERNEL);
>         if (!hdma_dev)
> -               return -EINVAL;
> +               return -ENOMEM;
>
>         hdma_dev->base = pcim_iomap_table(pdev)[PCI_BAR_2];
>         hdma_dev->pdev = pdev;
> --
> 2.51.0
>