From: Julia Lawall <julia.lawall@inria.fr>
To: sean.wang@mediatek.com, vkoul@kernel.org, matthias.bgg@gmail.com
Cc: dmaengine@vger.kernel.org, linux-mediatek@lists.infradead.org,
Nic Volanschi <eugene.volanschi@inria.fr>
Subject: question about drivers/dma/mediatek/mtk-cqdma.c
Date: Fri, 8 May 2020 23:57:17 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2005082352340.6525@hadrien> (raw)
Hello,
The function mtk_cqdma_find_active_desc contains the following code:
struct virt_dma_desc *vd;
unsigned long flags;
spin_lock_irqsave(&cvc->pc->lock, flags);
list_for_each_entry(vd, &cvc->pc->queue, node)
if (vd->tx.cookie == cookie) {
spin_unlock_irqrestore(&cvc->pc->lock, flags);
return vd;
}
That is, from a &cvc->pc->queue there is an iteration over elements of
type virt_dma_desc. But other uses of &cvc->pc->queue, such as in
mtk_cqdma_is_vchan_active, seem to indicate that the elements of this list
have type mtk_cqdma_vdesc. It is not clear to me how the body of the loop
should be updated to account for this.
thanks,
julia
reply other threads:[~2020-05-08 21:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2005082352340.6525@hadrien \
--to=julia.lawall@inria.fr \
--cc=dmaengine@vger.kernel.org \
--cc=eugene.volanschi@inria.fr \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@mediatek.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox