DMA Engine development
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
	Frank Li <Frank.Li@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	dmaengine@vger.kernel.org
Subject: Re: [PATCH 1/4] dmaengine: sh: rcar-dmac: fix style in struct initialization
Date: Tue, 25 Aug 2026 10:35:59 -0500	[thread overview]
Message-ID: <ao22X9RNzAWTYgGr@SMW015318> (raw)
In-Reply-To: <20260825141542.30901-7-wsa+renesas@sang-engineering.com>

On Tue, Aug 25, 2026 at 04:15:43PM +0200, Wolfram Sang wrote:
> A new member will be added to the struct. Before that, adhere to coding
> style by using a single space when assigning values.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/sh/rcar-dmac.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
> index 44eab2d21d54..cf07c17847d0 100644
> --- a/drivers/dma/sh/rcar-dmac.c
> +++ b/drivers/dma/sh/rcar-dmac.c
> @@ -1998,13 +1998,13 @@ static void rcar_dmac_shutdown(struct platform_device *pdev)
>  }
>
>  static const struct rcar_dmac_of_data rcar_dmac_data = {
> -	.chan_offset_base	= 0x8000,
> -	.chan_offset_stride	= 0x80,
> +	.chan_offset_base = 0x8000,
> +	.chan_offset_stride = 0x80,
>  };
>
>  static const struct rcar_dmac_of_data rcar_gen4_dmac_data = {
> -	.chan_offset_base	= 0x0,
> -	.chan_offset_stride	= 0x1000,
> +	.chan_offset_base = 0x0,
> +	.chan_offset_stride = 0x1000,
>  };
>
>  static const struct of_device_id rcar_dmac_of_ids[] = {
> --
> 2.47.3
>

  reply	other threads:[~2026-08-25 15:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25 14:15 [PATCH 0/4] dmaengine: sh: rcar-dmac: add R-Car Gen5 X5H support Wolfram Sang
2026-08-25 14:15 ` [PATCH 1/4] dmaengine: sh: rcar-dmac: fix style in struct initialization Wolfram Sang
2026-08-25 15:35   ` Frank Li [this message]
2026-09-04 12:29   ` Geert Uytterhoeven
2026-08-25 14:15 ` [PATCH 2/4] dmaengine: sh: rcar-dmac: SMMU doesn't need IPMMU workaround Wolfram Sang
2026-08-25 15:37   ` Frank Li
2026-09-04 12:44   ` Geert Uytterhoeven
2026-08-25 14:15 ` [PATCH 3/4] dt-bindings: renesas,rcar-dmac: Add support for R-Car X5H SoC Wolfram Sang
2026-08-28 10:12   ` Krzysztof Kozlowski
2026-09-04 12:59   ` Geert Uytterhoeven
2026-08-25 14:15 ` [PATCH 4/4] dmaengine: sh: rcar-dmac: Add support for R-Car Gen5 SoCs Wolfram Sang
2026-08-25 15:40   ` Frank Li
2026-08-26  8:17     ` Wolfram Sang
2026-09-04 13:01   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ao22X9RNzAWTYgGr@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=vkoul@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox