Re: [PATCH v6 13/23] dmaengine: ste_dma40: Fix probe LCLA free

[Frank Li <Frank.li@oss.nxp.com>]

On Thu, Sep 24, 2026 at 10:35:25AM +0200, Linus Walleij wrote:
> When LCLA is placed in ESRAM, d40_probe() stores a devm_ioremap()
> address in lcla_pool.base and leaves base_unaligned unset. The
> destroy_cache error path can then pass the ioremap address to
> free_pages().
>
> Only free lcla_pool.base with free_pages() when the driver allocated the
> LCLA pool from normal memory. The ESRAM mapping is devm-managed.
>
> Fixes: 339f5041089a ("dmaengine: ste_dma40: Use managed resources")
> Reported-by: sashiko-bot@kernel.org
> Closes: https://lore.kernel.org/dmaengine/20260819225114.AE1511F000E9@smtp.kernel.org/
> Assisted-by: LLM
> Signed-off-by: Linus Walleij <linusw@kernel.org>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/ste_dma40.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
> index 8998466faa76..b25e9ed5fcb9 100644
> --- a/drivers/dma/ste_dma40.c
> +++ b/drivers/dma/ste_dma40.c
> @@ -3913,7 +3913,8 @@ static int __init d40_probe(struct platform_device *pdev)
>  				 SZ_1K * base->num_phy_chans,
>  				 DMA_TO_DEVICE);
>
> -	if (!base->lcla_pool.base_unaligned && base->lcla_pool.base)
> +	if (!base->plat_data->use_esram_lcla &&
> +	    !base->lcla_pool.base_unaligned && base->lcla_pool.base)
>  		free_pages((unsigned long)base->lcla_pool.base,
>  			   base->lcla_pool.alloc_order);
>
>
> --
> 2.55.0
>