From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Koichiro Den <den@valinux.co.jp>
Cc: Frank Li <Frank.li@oss.nxp.com>,
linux-renesas-soc@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
Frank Li <Frank.Li@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dmaengine@vger.kernel.org
Subject: Re: [PATCH 2/3] dmaengine: rcar-dmac: Add missing dma_descriptor_unmap()
Date: Sun, 27 Sep 2026 15:11:26 +0200 [thread overview]
Message-ID: <arkV-ru3aNXDFawM@shikoro> (raw)
In-Reply-To: <arkPcxePb1G1vyZt@shikoro>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
> I share this thought, and I guess, Laurent expressed this, too. This is
> a separate task to tackle, though. I still think your original patch
> here makes the situation better by making sure the cache gets
> invalidated and should be applied. Or am I missing something?
Okay, I got now that Sashiko's comment was related to cookie-completion
and not the callback. For me, its comment also makes sense because it is
basically the same argument which the commits I quoted to Frank used:
ensure cache completion. This is not only good before the callback but
also before cookie completion. Or am I missing something?
This is easy to fix. If we can agree on switching unmapping before
cookie completion, I can update this patch and then send a series to fix
other drivers, too.
Opinions?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-09-27 13:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 7:12 [PATCH 0/3] dmaengine: rcar-dmac: collection of small missed fixes Wolfram Sang
2026-09-17 7:12 ` [PATCH 1/3] dmaengine: rcar-dmac: Fix PM usage counter imbalance Wolfram Sang
2026-09-17 7:17 ` Laurent Pinchart
2026-09-17 7:12 ` [PATCH 2/3] dmaengine: rcar-dmac: Add missing dma_descriptor_unmap() Wolfram Sang
2026-09-17 7:25 ` sashiko-bot
2026-09-17 7:38 ` Laurent Pinchart
2026-09-17 8:23 ` Wolfram Sang
2026-09-17 16:39 ` Frank Li
2026-09-18 13:07 ` Koichiro Den
2026-09-27 12:43 ` Wolfram Sang
2026-09-27 13:11 ` Wolfram Sang [this message]
2026-09-29 4:13 ` Koichiro Den
2026-09-27 12:38 ` Wolfram Sang
2026-09-17 7:12 ` [PATCH 3/3] dmaengine: rcar-dmac: Remove redundant dev_err()/dev_err_probe() Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arkV-ru3aNXDFawM@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=Frank.Li@kernel.org \
--cc=Frank.li@oss.nxp.com \
--cc=den@valinux.co.jp \
--cc=dmaengine@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox