From: Vinod Koul <vkoul@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Frank Li <Frank.li@oss.nxp.com>,
dmaengine@vger.kernel.org, Binbin Zhou <zhoubinbin@loongson.cn>,
Frank Li <Frank.Li@kernel.org>
Subject: Re: [PATCH v4] dmaengine: loongson: Remove the dev_dbg() output
Date: Mon, 5 Oct 2026 16:24:51 +0200 [thread overview]
Message-ID: <asOzMw3YIXi7GqJl@parshuram> (raw)
In-Reply-To: <20260921195745.gY25rf4P@linutronix.de>
On 21-09-26, 21:57, Sebastian Andrzej Siewior wrote:
> The %pK format modifier was meant for /proc kind of output, not general
> printk output. Since commit ad67b74d2469d ("printk: hash addresses
> printed with %p") pointers are hashed by default and the behaviour can
> be controller by `hash_pointers' boot argument.
> The policy on %p is to not introduce new ones.
>
> The output in loongson2_cmc_dma_issue_pending() is the only dev_dbg()
> output in the driver and is only output once the transfer is started.
> There is no output issued by the driver if the transfer is completed, if
> a follow-up transfer is started or if any of the other callbacks (such
> as loongson2_cmc_dma_tx_status()) are invoked. This output does not look
> essential.
>
> Instead removing just the %pK output, remove the complete dev_dbg()
> output from the driver.
This doesnt apply against the current code, pls rebase
--
~Vinod
prev parent reply other threads:[~2026-10-05 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 19:57 [PATCH v4] dmaengine: loongson: Remove the dev_dbg() output Sebastian Andrzej Siewior
2026-09-22 1:09 ` Binbin Zhou
2026-10-05 14:24 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asOzMw3YIXi7GqJl@parshuram \
--to=vkoul@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=Frank.li@oss.nxp.com \
--cc=bigeasy@linutronix.de \
--cc=dmaengine@vger.kernel.org \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox