From: Frank Li <Frank.li@oss.nxp.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>, Frank Li <Frank.Li@kernel.org>,
Sergey Khimich <serghox@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sia Jee Heng <jee.heng.sia@intel.com>,
Baruch Siach <baruch@tkos.co.il>,
Mitch Barnett <mitch@accuratesound.ca>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Wang YuWei <1973615295@qq.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v8 6/9] dmaengine: dw-axi-dmac: retain descriptors until callbacks drain
Date: Thu, 19 Nov 2026 10:41:31 -0600 [thread overview]
Message-ID: <av8mu_ZFxNKSgFTK@SMW015318> (raw)
In-Reply-To: <20261119-submit-dw-axi-dma-stop-pause-v1-v8-6-f8e7fe60594c@gmail.com>
On Thu, Nov 19, 2026 at 09:01:01AM -0700, James Hilliard wrote:
> Termination frees every descriptor while a pending period callback can
> still refer to one through vc->cyclic. An executing callback has already
> cleared that pointer, but still receives a pointer to the descriptor's
> tx_result and can use it after termination frees the descriptor.
>
> An error interrupt can also move the cyclic descriptor to desc_completed
> before termination. Looking only at the head of desc_issued therefore
> does not cover every pending cyclic callback.
>
> Use vchan_terminate_all() after stopping the channel to clear the pending
> alias and move the collected descriptors to desc_terminated. The existing
> synchronize callback drains the tasklet before reclaiming that list.
> Descriptors already detached onto the tasklet's private completed list
> remain owned by the tasklet. Repeated termination preserves the retired
> list, including when called from a completion callback.
>
> Fixes: 1deb96c0fa58 ("dmaegine: dw-axi-dmac: Support device_prep_dma_cyclic()")
> Reported-by: Wang YuWei <1973615295@qq.com>
> Link: https://lore.kernel.org/r/tencent_C00D995A9F70206DFD1330DCB1222EEBCB07@qq.com/
> Reported-by: Mitch Barnett <mitch@accuratesound.ca>
> Cc: Wang YuWei <1973615295@qq.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> index 99b648d4ca76..2547f9596ae6 100644
> --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> @@ -1202,7 +1202,6 @@ static int dma_chan_terminate_all(struct dma_chan *dchan)
> {
> struct axi_dma_chan *chan = dchan_to_axi_dma_chan(dchan);
> int ret;
> - LIST_HEAD(head);
>
> scoped_guard(spinlock_irqsave, &chan->vc.lock) {
> bool enabled;
> @@ -1219,7 +1218,7 @@ static int dma_chan_terminate_all(struct dma_chan *dchan)
> if (chan->direction == DMA_MEM_TO_DEV)
> dw_axi_dma_set_byte_halfword(chan, false);
>
> - vchan_get_all_descriptors(&chan->vc, &head);
> + vchan_terminate_all(&chan->vc);
I have not found this function, Any dependence I missed?
And keep allocate_queue when terminate,
https://lore.kernel.org/dmaengine/20261104-dma40-fixes-v1-1-48c5180f5210@kernel.org/
Look like we new APIs to distingiush terminate_all() and free channel.
when free channel, need clean alloc queue, but termiate_all() should be
keep alloc queue.
terminate should means terminate all DMA engine own's queue, before
submit, desc should be own by consumer.
Frank
>
> axi_chan_irq_clear(chan, DWAXIDMAC_IRQ_SUSPENDED);
> chan->desc = NULL;
> @@ -1234,8 +1233,6 @@ static int dma_chan_terminate_all(struct dma_chan *dchan)
> return ret;
> }
>
> - vchan_dma_desc_free_list(&chan->vc, &head);
> -
> dev_vdbg(dmaengine_chan_dev(dchan), "terminated: %s\n", axi_chan_name(chan));
>
> return 0;
>
> --
> 2.53.0
>
next prev parent reply other threads:[~2026-11-19 16:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 16:00 [PATCH v8 0/9] dmaengine: dw-axi-dmac: fix termination and pause acknowledgment James Hilliard
2026-11-19 16:00 ` [PATCH v8 1/9] dmaengine: dw-axi-dmac: keep cyclic mode in the descriptor James Hilliard
2026-11-19 16:00 ` [PATCH v8 2/9] dmaengine: dw-axi-dmac: poll the correct enable bit during termination James Hilliard
2026-11-19 16:17 ` Frank Li
2026-11-19 16:00 ` [PATCH v8 3/9] dmaengine: dw-axi-dmac: retain descriptors when termination times out James Hilliard
2026-11-19 16:18 ` Frank Li
2026-11-19 16:00 ` [PATCH v8 4/9] dmaengine: dw-axi-dmac: use atomic polling for suspend acknowledgment James Hilliard
2026-11-19 16:19 ` Frank Li
2026-11-19 16:01 ` [PATCH v8 5/9] dmaengine: dw-axi-dmac: preserve pending pause requests James Hilliard
2026-11-19 16:27 ` Frank Li
2026-11-19 16:01 ` [PATCH v8 6/9] dmaengine: dw-axi-dmac: retain descriptors until callbacks drain James Hilliard
2026-11-19 16:41 ` Frank Li [this message]
2026-11-19 16:01 ` [PATCH v8 7/9] dmaengine: dw-axi-dmac: serialize interrupt status with channel reuse James Hilliard
2026-11-19 16:44 ` Frank Li
2026-11-19 16:01 ` [PATCH v8 8/9] dmaengine: dw-axi-dmac: require an IRQ before registering the controller James Hilliard
2026-11-19 16:47 ` Frank Li
2026-11-19 16:01 ` [PATCH v8 9/9] dmaengine: dw-axi-dmac: guard shared IRQs across the controller lifetime James Hilliard
2026-11-19 16:50 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av8mu_ZFxNKSgFTK@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=1973615295@qq.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Frank.Li@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baruch@tkos.co.il \
--cc=dmaengine@vger.kernel.org \
--cc=james.hilliard1@gmail.com \
--cc=jee.heng.sia@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mitch@accuratesound.ca \
--cc=serghox@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox