Re: [PATCH v6 6/9] dmaengine: fsl-edma: use BIT_ULL for 64-bit channel mask

[Peng Fan <peng.fan@oss.nxp.com>]

On Thu, Nov 12, 2026 at 07:55:21AM +0000, sashiko-bot@kernel.org wrote:
>Thank you for your contribution! Sashiko AI review found 1 potential
>issue to consider:
>- [Low] dmaengine: fsl-edma: missing Fixes trailer for chan_masked
>  BIT_ULL() fix
>--
>
>commit 8e06ee65c51430e49223083e2d47b18afdf396c8
>Author: Peng Fan <peng.fan@nxp.com>
>
>> dmaengine: fsl-edma: use BIT_ULL for 64-bit channel mask
>>
>> chan_masked is a u64 bitmap, but several checks use BIT(), which uses
>> unsigned long and overflows on 32-bit architectures for channels >= 32.
>> Use BIT_ULL() so the upper channels are tested correctly.
>>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>
>[Severity: Low]
>Should this commit include a Fixes: tag for the commit that introduced the
>64-bit chan_masked bitmap and the initial BIT() checks (and optionally the
>follow-up commits that added the remaining checks)?

No need fix tag. Until now, we not have 32-architecture with more than 32
channels. There might be cases to run ARM64 platform in ARM32 mode as we
ever did for i.MX8MM, but we have not seen the case for i.MX8ULP/9, so no
need a fix tag.

Regards
Peng

>
>  Fixes: 72f5801a4e2b ("dmaengine: fsl-edma: integrate v3 support")
>  Fixes: 2838a897654c ("dmaengine: fsl-edma: Do not suspend and resume the masked dma channel when the system is sleeping")
>  Fixes: ccfa3131d4a0 ("dmaengine: fsl-edma: implement the cleanup path of fsl_edma3_attach_pd()")
>  Fixes: d175222f5e90 ("dmaegnine: fsl-edma: add edma error interrupt handler")
>
>-- 
>Sashiko AI review · https://sashiko.dev/#/patchset/20261112-edma-iommu-v3-v6-0-b038edb8ce6f@nxp.com?part=6
>
>