From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.117 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794927899; b=Ukri/GMP01QlqLgPHO9T3obrlozSyTFssJBLzfQ8kR/AXvs8Y+aRIR1qyvBSvhZjBdjZ qmFMPJLvsCs2jj8VPV3ciqVsK5c4I+h2BRHkFMCAbhX8gTQCpKz+ys9l4dBLfT1FyGcuD Bv7T2OFXmpNYoyByK+lLuFiioFa2av0JW1po1M89z064ZLc2khW3RH2W537J8xXVObCwJ eutDtlOuPfeeOzwkcuJb4CpCDxZOHHmmDoyLqYF49KM0vXuUXvAcJI8zwYxz/Dj9zICrd WVfzzwiaQBiG3EPmpwuY4xava3M0tzA35q9zGW9MdbQ5RSXZhutVjuOQisHI7r8ghbQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794927899; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=YGp9PC/3VbbJew7o6lt7FFNFnWRQ4swf3eWUT365kY4=; b=YROsVFsAqEN7Ya/4OcEcMH5FcL0cmulpTKh9Bes5pjH2hXIr7kB0sdK0ljhGtw/Y+rhW fYvA0BT802AFPCSwk+AkXLXfPVHQB0yNa9FVzHsBvi3RWqiWhs0NhgS1COv1i9q7g1fHX AnDIB4iD2stiXVCtSzLvyyKL7HHTkqqql1lN/7zhD0M6T8d4/x7xaSI0Ui+lNSMRWoVRz WlD1X3EP98OoMtvofDB7X5ardgX4Nfp4xPIAFgCs0JtzCdOWM+JVjC7qQuueq7SFbYd9W THUlJllMvEFD4lbLF+MRGjvnRE5ol5gc7SGOGPl9fKladO06yZG+sgbI3NazreGCD1A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=Gd6ZY2Up; arc=none smtp.remote-ip=91.218.175.117 Received: from mta0.migadu.com (out-117.mta0.migadu.com [91.218.175.117]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F62B606A334 for ; Tue, 17 Nov 2026 15:04:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 1F62B606A334 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=Gd6ZY2Up X-Envelope-To: dmaengine@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=EF8PbkYJiw2SNYIbhXqCwRQsFcWPdAKgl4U2nMsfivM=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794927896; v=1; x=1795532696; b=Gd6ZY2UpdrZJMbZpVdKAc3uir6WaMVnLKdTjum8VXcuGFY1YPLjTTyGn2Ktuoh2tal6aJY3t 0/60LtM700/6qvKKkA2U7OEHtJl9Kz5xQtyU3g/QWrW6Zcgl7ps2kqOUXU3Ptm4TPtdYd97xYQZ g4KmAm0xJpKl8qE1T91IgtLA= X-Envelope-To: dmaengine@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id b65b25fb13c5725a; Tue, 17 Nov 2026 15:04:55 +0000 X-Mizu-Trace-ID: b65b25fb13c5725a X-Migadu-Flow: FLOW_OUT Date: Tue, 17 Nov 2026 23:04:29 +0800 From: Peng Fan To: Jason Gunthorpe Cc: "Peng Fan (OSS)" , Frank Li , Vinod Koul , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Laxman Dewangan , Jon Hunter , Thierry Reding , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Larisa IIeana Grigore , imx@lists.linux.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan Subject: Re: [PATCH v6 0/9] dmaengine: add DMA channel bus and fsl-edma per-channel IOMMU support Message-ID: References: <20261112-edma-iommu-v3-v6-0-b038edb8ce6f@nxp.com> <20261116193021.GB2452510@ziepe.ca> <20261117130005.GC2606445@ziepe.ca> X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261117130005.GC2606445@ziepe.ca> On Tue, Nov 17, 2026 at 09:00:05AM -0400, Jason Gunthorpe wrote: >On Tue, Nov 17, 2026 at 04:30:15PM +0800, Peng Fan wrote: >> On Mon, Nov 16, 2026 at 03:30:21PM -0400, Jason Gunthorpe wrote: >> >On Thu, Nov 12, 2026 at 03:53:03PM +0800, Peng Fan (OSS) wrote: >> >> I used iommu-map for eDMA, but iommu experts rejected it: >> >> "Using iommu-map to describe synthetic dma_chan_dev devices that the >> >> kernel creates is the same kind of DT abuse from over here:" >> >> More info: https://lore.kernel.org/all/20260917144804.GI3196566@ziepe.ca/ >> >> >> >> So I followed here [2] as Krzysztof wrote for QCOM VPU: >> >> "Thanks Jason for context and detailed arguments. Robin did not chime in >> >> yet, but from what I understood the DT-child-node approach will be the >> >> way we should go here. >> >> >> >> I accept above point of view and I am fine with this, thus Vishnu and >> >> Vikash - please go ahead with DT-child-node solution we had some time ago." >> >> [2] https://lore.kernel.org/linux-iommu/c7b956a9-d3e8-4e18-b780-5d08f5cd2ca1@kernel.org/ >> >> >> >> This series adds per-channel DT child node support to fsl-edma and, as a >> >> prerequisite, introduces a proper bus for DMA channel devices. >> > >> >To be fair this is discouraged too, now that I've seen 3-4 people >> >trying to do exactly the same thing I'm not as positive about the >> >DT-child-node hack. >> >> I may not describe it clear in cover-letter. >> >> I understand the concern. Let me explain why I believe it is justified here >> rather than a hack. >> >> On i.MX eDMA each channel has its own interrupt, its own register region, >> and on i.MX8QM even its own power domain. Each channel may also have its >> own Stream ID, or share one when SIDs are scarce. These are genuine >> per-channel hardware resources, not software fiction. >> >> In dmaengine each channel is already modeled as a channel device (see >> dmaengine_chan_dev()), and this series puts those devices on a real bus >> (dmaengine_chan_bus_type) as a prerequisite. The DT child node simply >> describes that existing device, so its reg/interrupts/power-domains/iommus >> are attached per channel instead of as index-matched flat lists on the >> controller. > >If they are real devices then why can't they come out as platform >devices? > >I think you are overstating how independent they are. Many single >devices have per "channel" resources like MMIO and IRQs. That's >totally normal. It doesn't make the sub resources independent devices. > >AFAICT what you have here is some HW designer used SID where they >should have used SSID and you are trying to hack DT to make that >usable because Linux does not support a SID as SSID model today. Thanks Jason, that clarifies the core issue. Anyway, I agree that per-channel MMIO/IRQ/power-domains do not by themselves make the channels independent devices. The real problem is that the eDMA could have separate SIDs for channels that are logically part of one controller, i.e. it uses SID where an SSID/substream would be the natural model, and Linux does not support that today. So I'd like to step back from the DT child-node shape and propose a generic direction: - Keep the DMA controller as one device and describe its channel Stream IDs in the controller node (ordered list, no per-channel child nodes and no requester-ID map). - Add a generic dmaengine/IOMMU mechanism that assigns one of those Stream IDs to each dma_chan_dev, so the channel gets its own IOMMU context/domain without inventing a DT device. - Use the SMMUv3 shared-SID support (still under reviewing) for channels that must share a SID. This keeps DT describing real hardware (the controller's SIDs) and moves the Linux-specific unbundling into the core instead of a per-driver binding. Each channel occupies 64KB MMIO region and works independently. With separate DT node, it will be easy for us to do channel device passthrough when using Xen hypervisor. Now moving away from this, the remaining question is how to expose a channel for Xen/per-channel passthrough without a per-channel DT node, seems I need to add some code in Xen hypervisor to support channel passthrough. Would that direction be acceptable, or do you see SID-as-SSID support in the IOMMU core as the required longer-term fix? Vinod, Frank, from dmaengine perspective, do you have any comments? Rob, you reviewed DT binding patch, do you have any comments? > >Again, since this is the 3rd - 4th case like this, it seems like a >popular hardware choice and we should try to do better to make Linux >support if we can. Yeah, I saw QCOM VPU case and thought child node usage was agreed from Krzysztof's reply. So I use same idea here. Thanks, Peng > >Jason