From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
dmaengine@vger.kernel.org, imx@lists.linux.dev,
krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org,
peng.fan@nxp.com, robh@kernel.org, vkoul@kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: dma: fsl-edma: remove 'clocks' from required
Date: Tue, 9 Apr 2024 22:02:32 +0200 [thread overview]
Message-ID: <b15ad271-037e-4ee3-ad88-e8068d31c8c8@linaro.org> (raw)
In-Reply-To: <20240409185416.2224609-1-Frank.Li@nxp.com>
On 09/04/2024 20:54, Frank Li wrote:
> fsl,imx8qm-adma and fsl,imx8qm-edma don't require 'clocks'. Remove it from
> required and add 'if' block for other compatible string to keep the same
> restrictions.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>
> Notes:
> Change from v2 to v3
> - rebase to dmaengine/next
This fails...
>
> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> index 825f4715499e5..657a7d3ebf857 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> @@ -82,7 +82,6 @@ required:
> - compatible
> - reg
> - interrupts
> - - clocks
> - dma-channels
>
> allOf:
> @@ -187,6 +186,22 @@ allOf:
> "#dma-cells":
> const: 3
>
> + - if:
> + properties:
> + compatible:
> + contains:
It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-09 20:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 18:54 [PATCH v3 1/2] dt-bindings: dma: fsl-edma: remove 'clocks' from required Frank Li
2024-04-09 18:54 ` [PATCH v3 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property Frank Li
2024-04-09 20:02 ` Krzysztof Kozlowski [this message]
2024-04-09 21:09 ` [PATCH v3 1/2] dt-bindings: dma: fsl-edma: remove 'clocks' from required Frank Li
2024-04-10 6:30 ` Krzysztof Kozlowski
2024-04-10 6:32 ` Krzysztof Kozlowski
2024-04-10 6:47 ` Krzysztof Kozlowski
2024-04-10 16:24 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b15ad271-037e-4ee3-ad88-e8068d31c8c8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox