From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 543674756B4 for ; Fri, 25 Sep 2026 14:10:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790345457; cv=none; b=Dsl8zF08Gh1xJuO2BdL/QoBrAC4x9UUlphf0u/IBKrt172WatSSHcT/2p36Xr0roaBVTXO/C7XAXN6O9chS27DaC7RDkdN0cin7h98jzXP3dey/WdyW9ME7r0UZNTybo2U8XBbQUIUU0tlG+UEXrow/5rPdPvj43TOhCJsHUCOw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790345457; c=relaxed/simple; bh=itBJES60RMp9qTnVjDVU6fwJJ9IUAne92eVMwTA1po8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TIpTMhfnQrYkdBOy8q+JuOnayPDTM2CUq8qzBbQkwHDHPsV9EVNAWY83PX6kBytW1zmxtWEKgJtLWHvYrhzQ40SI/sxjqlV2WjzH8/B1D6AGsHroHQyVuBZmXUQ04y0ATcNSQUR31y7r4/nuN8OIynvJqOiY2Nk7NUw5+BQLrfw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QUvINafy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=drfeb5lj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QUvINafy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="drfeb5lj" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68PDdlbv1193851 for ; Fri, 25 Sep 2026 14:10:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qgVIs0/RJKVOv08WQ9oErS5WnuLl2yv8yGRz8Gn+/YU=; b=QUvINafySfh61Y8i 7iSJlG09r1YiPJh5vYN0UW6hlCgKoi6OY2OjlG1hljwqWZGG4GWBwjAeYN3DPy5s lHARp35SoiNH7N2hO9iHKmbjsD0dfkJNKoDoOFKirtrFqfvT314PGcpyPRNqDgc1 nqA7f5Onz9nnZN5jxIV0hTtAeECKy7Jv7IXOOuBuqNsIYi+iq2HgO2OfWb+DljyK Z6KsFRzsGMEZgsZXWvsK05Pcc065ZQn7BLEiO0jQsEAZwu5HxcHm+344HUtenst2 ycl4WYd1MM4lI6YjaBtJmIFlwX5ZxXbF3nUIEC0MSduGhfwLyOWCJw0bOEqMW5pa oPI9pA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw874kqtt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 25 Sep 2026 14:10:54 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38ecc48b3c2so1942406a91.1 for ; Fri, 25 Sep 2026 07:10:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790345454; x=1790950254; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qgVIs0/RJKVOv08WQ9oErS5WnuLl2yv8yGRz8Gn+/YU=; b=drfeb5ljfuGrZdxvG64a95wyY0GRl7CG6/pYHWeViPEdBLDxHT14D/V5gRdOesY1qX D62+cW8ibaqmu1slpLYqXQ6oBf0G432umKYWelrTUc2fA3yl0Bit6X94V4ByeAMIpeyb OlNcqnV99WxGBl1vUk46sNxuQzQscmLceIoSrkDzmYng8qAcCIPLjZr/7FVlc9dty+3v 2F40sWrXfTClbPzVood7nID3RLBEEAHONotRSMfOnUErHP/F70M8KGDHKvOtC74w7+I5 Aeyn2B8VJg3RHa7pkc6RnY8Sdqj19F/HVpGAE+23auNSsrSZvsUnzZToquRoRl/MVsVJ Bs/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790345454; x=1790950254; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qgVIs0/RJKVOv08WQ9oErS5WnuLl2yv8yGRz8Gn+/YU=; b=thTfFaKJTat+Hd4kNvjlMspnC5wEgKmH86v45VXfBJCCTDd9z/2wPl+UJ8K5n2hdsE 3LBvT8/Zu6oIxXuyD1cdh+1YvwRZro53v2w78hfeJHdm9+hrhpQBcMTTOHCffSLBZosW 3oglaKoe4IeurlYIBe4ZuuyavafHz26H/axoHWUzm+g3m9EZRrUWF2IfpMMz3RJKMF50 onumpUPj/7f4ud2GHmNEO3pMVbheT8dLkFLGWiZSvS/p+P8Nc3Rt8qF7S4NwKUrTeimy VfwvRqQEr4gkFUg0tqS9F8JNDhYWZLmM2P0nf6fOxESn1eU9GIrLeJZ9ebrLivrP8ev/ vunA== X-Forwarded-Encrypted: i=1; AKwUvBzxKWrPd+NzfZTom47wsTWkbvl7+Z1I1QNkMWU8V6uHp8IsgNte5XMVny9SC3CRkQIkxeClGIib6mQ=@vger.kernel.org X-Gm-Message-State: AFuF++kPsZxQw3k+3ezMIVyL8ehJYFmCYCkdNpvm5DNHXIBwGtJRyMs+ jSHIUMZExKeaKJ2L0BSNe2+QgBN2MXXsxNTcBRG+vrJqc3FbzmDuOHlrVArIA9tV4sZkRcha57f IP6QuLLqRDL3NXa8+DTtxQ/g+KuhKb/WMdNSEy36Thw6ozOyjfF22n6TyHz13X6rGk31+ioc= X-Gm-Gg: AYBFou1O8ThYlIpR142JdsbOpgylEnx0XwO3v08JjTyuKiDUYyNosjyykTGjVFXSjf6 dfMwl9qRMdcQpF6uXa8Ixbe3ySeKj87lXmZ6oOLcP1pPy1prAVf8jAqw6KvPWGHo0b2DUSefQlL ph+t1ztZMXujNvcNIv0rXMqeydxzktshsbffIzyQsMyzaSLgNRuZcxFIGtEkWjfhVhm407ZlIkP X3dvlRFI/8T6f23+Pvz4VOWbGoX9On/ob5KHIg3iUwYnMoRd8Vwhc3kx17DmaJ/LGnr9zP/1YmL mFJrw2dhLqJut2ySmElgxgvsfkr9L8K6vMd97YBMcqNNXNwcRk9tMOig03aWXQcbrsB9yY6bEy4 ZiOvg9/vqZc0Iao9V55H5nL9BYhv4TQc= X-Received: by 2002:a17:90a:d40b:b0:39d:f2a1:3a with SMTP id 98e67ed59e1d1-3a0bb573f4amr2062389a91.15.1790345453384; Fri, 25 Sep 2026 07:10:53 -0700 (PDT) X-Received: by 2002:a17:90a:d40b:b0:39d:f2a1:3a with SMTP id 98e67ed59e1d1-3a0bb573f4amr2062342a91.15.1790345452588; Fri, 25 Sep 2026 07:10:52 -0700 (PDT) Received: from [192.168.0.3] ([49.204.107.168]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2df91461d38sm11277345ad.76.2026.09.25.07.10.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Sep 2026 07:10:51 -0700 (PDT) Message-ID: Date: Fri, 25 Sep 2026 19:40:46 +0530 Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] dmaengine: qcom: gpi: Convert dev_dbg() calls to tracepoints To: Frank Li Cc: konrad.dybcio@oss.qualcomm.com, Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Vinod Koul , Frank Li , chandana.chiluveru@oss.qualcomm.com, mukesh.savaliya@oss.qualcomm.com, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org References: <20260909-add-trace-support-gpio-v2-0-01f81739bb88@oss.qualcomm.com> <20260909-add-trace-support-gpio-v2-3-01f81739bb88@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: fNLDsqUwwtd6o1VOZM1rqnpgf3TYkcxQ X-Authority-Analysis: v=2.4 cv=MI71C8Zl c=1 sm=1 tr=0 ts=6ab680ee cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=LbQqD9KVPf5lhnc1gAYl9w==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=d3xK7mIYCK7McAmqHKAA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI1MDA1NiBTYWx0ZWRfX2rqzxJ7kdZSQ 9EDtxebogHQUkT2NlNv9NBN6jMewsYm4FZ2YbeGWAriNukpDOkDJ+9GyIajtaJBYt+ayUofBDyo COfQh8kqcnwHRLxrm9B9QctzHAYXhru4BlLXWwE815D42FtTfnQk2qMw7iNe7uDfmleufQt2SxI HdFl22oTrZBDRgCLly5X3HF4R6mCgkFDkmrbhIQBb7nxq+VWgs8h7/EniRgSHWKScuUJ8ICiLVC jg5Wbz/yO4sVioGzh0qX7VE3thVYP/nXytLrKTJ9/v3e4L3ACVE1qZSYwgu87qO1loolZei3gVA vJZp2RW5682Z4b0BMyrQ87OzjaH5EZLsJ7niM97LWzYZLOE7heidDSDxMsWC9qqGsGNxQ1ix+FE 8EMGRe1O7JxOpvRjPDd1VxB/6JLX71B7eR69G8lMkvqmzwF8FrdTclTSScOVcM3/Qx6r8ozvAgU TCxAcyIWQv0ENJS0BVA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI1MDA1NiBTYWx0ZWRfXw6T1C8LSSn0N ge6hiWCa0MDjhPlggzi5xsyx08CxjG0kinfVDT3IPx1FRJHW4LLtULRg3GrVs39fOapROx0xRO3 00zAHp9L1xH9zW1umv9cDtWqdCveiLY= X-Proofpoint-GUID: fNLDsqUwwtd6o1VOZM1rqnpgf3TYkcxQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-25_02,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 clxscore=1015 spamscore=0 priorityscore=1501 impostorscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609250056 Hi On 10-09-2026 02:28, Frank Li wrote: > On Wed, Sep 09, 2026 at 10:39:43AM +0530, Praveen Talari wrote: >> Replace the remaining dev_dbg() based debug logging in the GPI DMA >> driver with the qcom_gpi tracepoints, providing structured runtime >> visibility into GPI DMA behavior without requiring invasive debug >> patches. dev_err() calls are left untouched. >> >> Tracepoints are added at the same points as the dev_dbg() calls they >> replace: channel/event command dispatch in gpi_send_cmd(), error and >> top-level interrupt status in gpi_process_gen_err_irq() and >> gpi_handle_irq(), event/channel control state transitions in the IRQ >> handler and gpi_process_ch_ctrl_irq(), completion event handling >> (including the no-pending-descriptor and transfer result paths) in >> gpi_process_imed_data_event(), gpi_process_xfer_compl_event() and >> gpi_process_events(), ring allocation details in gpi_alloc_ring(), >> already-in-state checks in gpi_pause()/gpi_resume(), TRE contents in >> gpi_create_i2c_tre()/gpi_create_spi_tre(), and TRE queuing in >> gpi_issue_pending(). > needn't this paragraph. The first paragraph is clear enough. Sure, will update in next patch. Thanks, Praveen > > Frank >> Signed-off-by: Praveen Talari >> --- >> drivers/dma/qcom/gpi.c | 58 ++++++++++++++------------------------------------ >> 1 file changed, 16 insertions(+), 42 deletions(-) >> >> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c >> index b09354a73b46..8e7d25a46147 100644 >> --- a/drivers/dma/qcom/gpi.c >> +++ b/drivers/dma/qcom/gpi.c >> @@ -684,8 +684,6 @@ static int gpi_send_cmd(struct gpii *gpii, struct gchan *gchan, >> if (IS_CHAN_CMD(gpi_cmd)) >> chid = gchan->chid; >> >> - dev_dbg(gpii->gpi_dev->dev, >> - "sending cmd: %s:%u\n", TO_GPI_CMD_STR(gpi_cmd), chid); >> trace_gpi_send_cmd(gpii->gpi_dev->dev, chid, gpi_cmd, TO_GPI_CMD_STR(gpi_cmd)); >> >> /* send opcode and wait for completion */ >> @@ -797,7 +795,7 @@ static void gpi_process_gen_err_irq(struct gpii *gpii) >> u32 irq_stts = gpi_read_reg(gpii, gpii->regs + offset); >> >> /* clear the status */ >> - dev_dbg(gpii->gpi_dev->dev, "irq_stts:0x%x\n", irq_stts); >> + trace_gpi_gen_err_irq(gpii->gpi_dev->dev, gpii_id, irq_stts); >> >> /* Clear the register */ >> offset = GPII_n_CNTXT_GPII_IRQ_CLR_OFFS(gpii_id); >> @@ -866,8 +864,6 @@ static irqreturn_t gpi_handle_irq(int irq, void *data) >> u32 ev_state; >> u32 ev_ch_irq; >> >> - dev_dbg(gpii->gpi_dev->dev, >> - "processing EV CTRL interrupt\n"); >> offset = GPII_n_CNTXT_SRC_EV_CH_IRQ_OFFS(gpii_id); >> ev_ch_irq = gpi_read_reg(gpii, gpii->regs + offset); >> >> @@ -887,15 +883,14 @@ static irqreturn_t gpi_handle_irq(int irq, void *data) >> ev_state = DEFAULT_EV_CH_STATE; >> >> gpii->ev_state = ev_state; >> - dev_dbg(gpii->gpi_dev->dev, "setting EV state to %s\n", >> - TO_GPI_EV_STATE_STR(gpii->ev_state)); >> + trace_gpi_ev_ctrl_irq(gpii->gpi_dev->dev, gpii_id, ev_ch_irq, >> + gpii->ev_state); >> complete_all(&gpii->cmd_completion); >> type &= ~(GPII_n_CNTXT_TYPE_IRQ_MSK_EV_CTRL); >> } >> >> /* channel control irq */ >> if (type & GPII_n_CNTXT_TYPE_IRQ_MSK_CH_CTRL) { >> - dev_dbg(gpii->gpi_dev->dev, "process CH CTRL interrupts\n"); >> gpi_process_ch_ctrl_irq(gpii); >> type &= ~(GPII_n_CNTXT_TYPE_IRQ_MSK_CH_CTRL); >> } >> @@ -945,17 +940,10 @@ static void gpi_process_imed_data_event(struct gchan *gchan, >> struct gpi_tre *gpi_tre; >> >> spin_unlock_irqrestore(&gchan->vc.lock, flags); >> - dev_dbg(gpii->gpi_dev->dev, "event without a pending descriptor!\n"); >> gpi_ere = (struct gpi_ere *)imed_event; >> - dev_dbg(gpii->gpi_dev->dev, >> - "Event: %08x %08x %08x %08x\n", >> - gpi_ere->dword[0], gpi_ere->dword[1], >> - gpi_ere->dword[2], gpi_ere->dword[3]); >> gpi_tre = tre; >> - dev_dbg(gpii->gpi_dev->dev, >> - "Pending TRE: %08x %08x %08x %08x\n", >> - gpi_tre->dword[0], gpi_tre->dword[1], >> - gpi_tre->dword[2], gpi_tre->dword[3]); >> + trace_gpi_ev_no_desc(gpii->gpi_dev->dev, imed_event->chid, >> + gpi_ere->dword, gpi_tre->dword); >> return; >> } >> gpi_desc = to_gpi_desc(vd); >> @@ -1064,11 +1052,10 @@ static void gpi_process_xfer_compl_event(struct gchan *gchan, >> dev_err(gpii->gpi_dev->dev, "Error in Transaction\n"); >> result.result = DMA_TRANS_ABORTED; >> } else { >> - dev_dbg(gpii->gpi_dev->dev, "Transaction Success\n"); >> result.result = DMA_TRANS_NOERROR; >> } >> result.residue = gpi_desc->len - compl_event->length; >> - dev_dbg(gpii->gpi_dev->dev, "Residue %d\n", result.residue); >> + trace_gpi_xfer_result(gpii->gpi_dev->dev, chid, result.result, result.residue); >> >> dma_cookie_complete(&vd->tx); >> dmaengine_desc_get_callback_invoke(&vd->tx, &result); >> @@ -1100,11 +1087,8 @@ static void gpi_process_events(struct gpii *gpii) >> chid = gpi_event->xfer_compl_event.chid; >> type = gpi_event->xfer_compl_event.type; >> >> - dev_dbg(gpii->gpi_dev->dev, >> - "Event: CHID:%u, type:%x %08x %08x %08x %08x\n", >> - chid, type, gpi_event->gpi_ere.dword[0], >> - gpi_event->gpi_ere.dword[1], gpi_event->gpi_ere.dword[2], >> - gpi_event->gpi_ere.dword[3]); >> + trace_gpi_process_event(gpii->gpi_dev->dev, chid, type, >> + gpi_event->gpi_ere.dword); >> >> switch (type) { >> case XFER_COMPLETE_EV_TYPE: >> @@ -1113,7 +1097,6 @@ static void gpi_process_events(struct gpii *gpii) >> &gpi_event->xfer_compl_event); >> break; >> case STALE_EV_TYPE: >> - dev_dbg(gpii->gpi_dev->dev, "stale event, not processing\n"); >> break; >> case IMMEDIATE_DATA_EV_TYPE: >> gchan = &gpii->gchan[chid]; >> @@ -1121,11 +1104,8 @@ static void gpi_process_events(struct gpii *gpii) >> &gpi_event->immediate_data_event); >> break; >> case QUP_NOTIF_EV_TYPE: >> - dev_dbg(gpii->gpi_dev->dev, "QUP_NOTIF_EV_TYPE\n"); >> break; >> default: >> - dev_dbg(gpii->gpi_dev->dev, >> - "not supported event type:0x%x\n", type); >> } >> gpi_ring_recycle_ev_element(ev_ring); >> } >> @@ -1409,10 +1389,8 @@ static int gpi_alloc_ring(struct gpi_ring *ring, u32 elements, >> bit++; >> len = 1 << bit; >> ring->alloc_size = (len + (len - 1)); >> - dev_dbg(gpii->gpi_dev->dev, >> - "#el:%u el_size:%u len:%u actual_len:%llu alloc_size:%zu\n", >> - elements, el_size, (elements * el_size), len, >> - ring->alloc_size); >> + trace_gpi_alloc_ring(gpii->gpi_dev->dev, elements, el_size, >> + (elements * el_size), len, ring->alloc_size); >> >> ring->pre_aligned = dma_alloc_coherent(gpii->gpi_dev->dev, >> ring->alloc_size, >> @@ -1437,10 +1415,8 @@ static int gpi_alloc_ring(struct gpi_ring *ring, u32 elements, >> /* update to other cores */ >> smp_wmb(); >> >> - dev_dbg(gpii->gpi_dev->dev, >> - "phy_pre:%pad phy_alig:%pa len:%u el_size:%u elements:%u\n", >> - &ring->dma_handle, &ring->phys_addr, ring->len, >> - ring->el_size, ring->elements); >> + trace_gpi_ring_info(gpii->gpi_dev->dev, ring->dma_handle, ring->phys_addr, >> + ring->len, ring->el_size, ring->elements); >> >> return 0; >> } >> @@ -1542,7 +1518,7 @@ static int gpi_pause(struct dma_chan *chan) >> * client needs to call pause only once >> */ >> if (gpii->pm_state == PAUSE_STATE) { >> - dev_dbg(gpii->gpi_dev->dev, "channel is already paused\n"); >> + trace_gpi_already_state(gpii->gpi_dev->dev, gpii->gpii_id, gpii->pm_state); >> mutex_unlock(&gpii->ctrl_lock); >> return 0; >> } >> @@ -1578,7 +1554,7 @@ static int gpi_resume(struct dma_chan *chan) >> >> mutex_lock(&gpii->ctrl_lock); >> if (gpii->pm_state == ACTIVE_STATE) { >> - dev_dbg(gpii->gpi_dev->dev, "channel is already active\n"); >> + trace_gpi_already_state(gpii->gpi_dev->dev, gpii->gpii_id, gpii->pm_state); >> mutex_unlock(&gpii->ctrl_lock); >> return 0; >> } >> @@ -1703,8 +1679,7 @@ static int gpi_create_i2c_tre(struct gchan *chan, struct gpi_desc *desc, >> } >> >> for (i = 0; i < tre_idx; i++) >> - dev_dbg(dev, "TRE:%d %x:%x:%x:%x\n", i, desc->tre[i].dword[0], >> - desc->tre[i].dword[1], desc->tre[i].dword[2], desc->tre[i].dword[3]); >> + trace_gpi_tre(dev, chan->chid, i, desc->tre[i].dword); >> >> return tre_idx; >> } >> @@ -1797,8 +1772,7 @@ static int gpi_create_spi_tre(struct gchan *chan, struct gpi_desc *desc, >> TRE_FLAGS_IEOT); >> >> for (i = 0; i < tre_idx; i++) >> - dev_dbg(dev, "TRE:%d %x:%x:%x:%x\n", i, desc->tre[i].dword[0], >> - desc->tre[i].dword[1], desc->tre[i].dword[2], desc->tre[i].dword[3]); >> + trace_gpi_tre(dev, chan->chid, i, desc->tre[i].dword); >> >> return tre_idx; >> } >> >> -- >> 2.34.1 >>