* [PATCH] dt-bindings: dma: img-mdc-dma: convert to DT schema @ 2025-08-21 15:02 Nino Zhang 2025-08-22 19:50 ` Rob Herring 2025-08-24 3:45 ` [PATCH v2] " Nino Zhang 0 siblings, 2 replies; 5+ messages in thread From: Nino Zhang @ 2025-08-21 15:02 UTC (permalink / raw) To: vkoul Cc: robh, krzk+dt, conor+dt, dmaengine, devicetree, linux-kernel, Nino Zhang Convert the img-mdc-dma binding from txt to YAML schema. No functional changes except dropping the consumer node (spi@18100f00) from the example, which belongs to the consumer binding instead. Tested with 'make dt_binding_check'. Signed-off-by: Nino Zhang <ninozhang001@gmail.com> --- .../devicetree/bindings/dma/img-mdc-dma.txt | 57 ----------- .../devicetree/bindings/dma/img-mdc-dma.yaml | 98 +++++++++++++++++++ 2 files changed, 98 insertions(+), 57 deletions(-) delete mode 100644 Documentation/devicetree/bindings/dma/img-mdc-dma.txt create mode 100644 Documentation/devicetree/bindings/dma/img-mdc-dma.yaml diff --git a/Documentation/devicetree/bindings/dma/img-mdc-dma.txt b/Documentation/devicetree/bindings/dma/img-mdc-dma.txt deleted file mode 100644 index 28c1341db346..000000000000 --- a/Documentation/devicetree/bindings/dma/img-mdc-dma.txt +++ /dev/null @@ -1,57 +0,0 @@ -* IMG Multi-threaded DMA Controller (MDC) - -Required properties: -- compatible: Must be "img,pistachio-mdc-dma". -- reg: Must contain the base address and length of the MDC registers. -- interrupts: Must contain all the per-channel DMA interrupts. -- clocks: Must contain an entry for each entry in clock-names. - See ../clock/clock-bindings.txt for details. -- clock-names: Must include the following entries: - - sys: MDC system interface clock. -- img,cr-periph: Must contain a phandle to the peripheral control syscon - node which contains the DMA request to channel mapping registers. -- img,max-burst-multiplier: Must be the maximum supported burst size multiplier. - The maximum burst size is this value multiplied by the hardware-reported bus - width. -- #dma-cells: Must be 3: - - The first cell is the peripheral's DMA request line. - - The second cell is a bitmap specifying to which channels the DMA request - line may be mapped (i.e. bit N set indicates channel N is usable). - - The third cell is the thread ID to be used by the channel. - -Optional properties: -- dma-channels: Number of supported DMA channels, up to 32. If not specified - the number reported by the hardware is used. - -Example: - -mdc: dma-controller@18143000 { - compatible = "img,pistachio-mdc-dma"; - reg = <0x18143000 0x1000>; - interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 28 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 29 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 30 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 31 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 32 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 33 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 34 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 35 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 36 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 37 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 38 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&system_clk>; - clock-names = "sys"; - - img,max-burst-multiplier = <16>; - img,cr-periph = <&cr_periph>; - - #dma-cells = <3>; -}; - -spi@18100f00 { - ... - dmas = <&mdc 9 0xffffffff 0>, <&mdc 10 0xffffffff 0>; - dma-names = "tx", "rx"; - ... -}; diff --git a/Documentation/devicetree/bindings/dma/img-mdc-dma.yaml b/Documentation/devicetree/bindings/dma/img-mdc-dma.yaml new file mode 100644 index 000000000000..b635125d7ae3 --- /dev/null +++ b/Documentation/devicetree/bindings/dma/img-mdc-dma.yaml @@ -0,0 +1,98 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/dma/img-mdc-dma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: IMG Multi-threaded DMA Controller (MDC) + +maintainers: + - Vinod Koul <vkoul@kernel.org> + +allOf: + - $ref: /schemas/dma/dma-controller.yaml# + +properties: + compatible: + description: Must be "img,pistachio-mdc-dma". + const: img,pistachio-mdc-dma + + reg: + description: + Must contain the base address and length of the MDC registers. + minItems: 1 + + interrupts: + description: + Must contain all the per-channel DMA interrupts. + + clocks: + description: | + Must contain an entry for each entry in clock-names. + See clock/clock.yaml for details. + + clock-names: + description: | + Must include the following entries: + - sys: MDC system interface clock. + minItems: 1 + contains: { const: sys } + + img,cr-periph: + $ref: /schemas/types.yaml#/definitions/phandle + description: | + Must contain a phandle to the peripheral control syscon node + which contains the DMA request to channel mapping registers. + + img,max-burst-multiplier: + description: | + Must be the maximum supported burst size multiplier. + The maximum burst size is this value multiplied by the + hardware-reported bus width. + $ref: /schemas/types.yaml#/definitions/uint32 + + "#dma-cells": + description: | + Must be 3: + - The first cell is the peripheral's DMA request line. + - The second cell is a bitmap specifying to which channels the DMA request + line may be mapped (i.e. bit N set indicates channel N is usable). + - The third cell is the thread ID to be used by the channel. + const: 3 + + dma-channels: + description: | + Number of supported DMA channels, up to 32. If not specified + the number reported by the hardware is used. + $ref: /schemas/types.yaml#/definitions/uint32 + maximum: 32 + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + - "img,cr-periph" + - "img,max-burst-multiplier" + - "#dma-cells" + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/mips-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + mdc: dma-controller@18143000 { + compatible = "img,pistachio-mdc-dma"; + reg = <0x18143000 0x1000>; + interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SHARED 28 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&system_clk>; + clock-names = "sys"; + + img,max-burst-multiplier = <16>; + img,cr-periph = <&cr_periph>; + + #dma-cells = <3>; + }; -- 2.43.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: dma: img-mdc-dma: convert to DT schema 2025-08-21 15:02 [PATCH] dt-bindings: dma: img-mdc-dma: convert to DT schema Nino Zhang @ 2025-08-22 19:50 ` Rob Herring 2025-08-24 18:55 ` Nino Zhang 2025-08-24 3:45 ` [PATCH v2] " Nino Zhang 1 sibling, 1 reply; 5+ messages in thread From: Rob Herring @ 2025-08-22 19:50 UTC (permalink / raw) To: Nino Zhang; +Cc: vkoul, krzk+dt, conor+dt, dmaengine, devicetree, linux-kernel On Thu, Aug 21, 2025 at 11:02:55PM +0800, Nino Zhang wrote: > Convert the img-mdc-dma binding from txt to YAML schema. > No functional changes except dropping the consumer node > (spi@18100f00) from the example, which belongs to the > consumer binding instead. > > Tested with 'make dt_binding_check'. No need to say that in the commit msg. It is assumed you did this. > > Signed-off-by: Nino Zhang <ninozhang001@gmail.com> > --- > .../devicetree/bindings/dma/img-mdc-dma.txt | 57 ----------- > .../devicetree/bindings/dma/img-mdc-dma.yaml | 98 +++++++++++++++++++ > 2 files changed, 98 insertions(+), 57 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/dma/img-mdc-dma.txt > create mode 100644 Documentation/devicetree/bindings/dma/img-mdc-dma.yaml > > diff --git a/Documentation/devicetree/bindings/dma/img-mdc-dma.txt b/Documentation/devicetree/bindings/dma/img-mdc-dma.txt > deleted file mode 100644 > index 28c1341db346..000000000000 > --- a/Documentation/devicetree/bindings/dma/img-mdc-dma.txt > +++ /dev/null > @@ -1,57 +0,0 @@ > -* IMG Multi-threaded DMA Controller (MDC) > - > -Required properties: > -- compatible: Must be "img,pistachio-mdc-dma". > -- reg: Must contain the base address and length of the MDC registers. > -- interrupts: Must contain all the per-channel DMA interrupts. > -- clocks: Must contain an entry for each entry in clock-names. > - See ../clock/clock-bindings.txt for details. > -- clock-names: Must include the following entries: > - - sys: MDC system interface clock. > -- img,cr-periph: Must contain a phandle to the peripheral control syscon > - node which contains the DMA request to channel mapping registers. > -- img,max-burst-multiplier: Must be the maximum supported burst size multiplier. > - The maximum burst size is this value multiplied by the hardware-reported bus > - width. > -- #dma-cells: Must be 3: > - - The first cell is the peripheral's DMA request line. > - - The second cell is a bitmap specifying to which channels the DMA request > - line may be mapped (i.e. bit N set indicates channel N is usable). > - - The third cell is the thread ID to be used by the channel. > - > -Optional properties: > -- dma-channels: Number of supported DMA channels, up to 32. If not specified > - the number reported by the hardware is used. > - > -Example: > - > -mdc: dma-controller@18143000 { > - compatible = "img,pistachio-mdc-dma"; > - reg = <0x18143000 0x1000>; > - interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SHARED 28 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SHARED 29 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SHARED 30 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SHARED 31 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SHARED 32 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SHARED 33 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SHARED 34 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SHARED 35 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SHARED 36 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SHARED 37 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SHARED 38 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&system_clk>; > - clock-names = "sys"; > - > - img,max-burst-multiplier = <16>; > - img,cr-periph = <&cr_periph>; > - > - #dma-cells = <3>; > -}; > - > -spi@18100f00 { > - ... > - dmas = <&mdc 9 0xffffffff 0>, <&mdc 10 0xffffffff 0>; > - dma-names = "tx", "rx"; > - ... > -}; > diff --git a/Documentation/devicetree/bindings/dma/img-mdc-dma.yaml b/Documentation/devicetree/bindings/dma/img-mdc-dma.yaml > new file mode 100644 > index 000000000000..b635125d7ae3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/img-mdc-dma.yaml Use the compatible string for the filename. > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/img-mdc-dma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: IMG Multi-threaded DMA Controller (MDC) > + > +maintainers: > + - Vinod Koul <vkoul@kernel.org> No, must be someone with this h/w and cares about this h/w. > + > +allOf: > + - $ref: /schemas/dma/dma-controller.yaml# > + > +properties: > + compatible: > + description: Must be "img,pistachio-mdc-dma". Drop. The schema says that. Same goes for all the other descriptions, so I won't repeat it everywhere. > + const: img,pistachio-mdc-dma > + > + reg: > + description: > + Must contain the base address and length of the MDC registers. Drop. > + minItems: 1 maxItems instead. > + > + interrupts: > + description: > + Must contain all the per-channel DMA interrupts. Must define how many. > + > + clocks: > + description: | > + Must contain an entry for each entry in clock-names. > + See clock/clock.yaml for details. Drop. Must define how many clocks and what they are. > + > + clock-names: > + description: | > + Must include the following entries: > + - sys: MDC system interface clock. Drop. The schema says that. > + minItems: 1 > + contains: { const: sys } Must be exact list of values, not 'sys' plus anything else you want. > + > + img,cr-periph: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: | Drop '|'. Not needed if no formatting to maintain. > + Must contain a phandle to the peripheral control syscon node > + which contains the DMA request to channel mapping registers. > + > + img,max-burst-multiplier: > + description: | > + Must be the maximum supported burst size multiplier. > + The maximum burst size is this value multiplied by the > + hardware-reported bus width. Wrap lines at 80 and drop '|'. > + $ref: /schemas/types.yaml#/definitions/uint32 constraints? > + > + "#dma-cells": > + description: | > + Must be 3: > + - The first cell is the peripheral's DMA request line. > + - The second cell is a bitmap specifying to which channels the DMA request > + line may be mapped (i.e. bit N set indicates channel N is usable). > + - The third cell is the thread ID to be used by the channel. > + const: 3 > + > + dma-channels: > + description: | > + Number of supported DMA channels, up to 32. If not specified > + the number reported by the hardware is used. > + $ref: /schemas/types.yaml#/definitions/uint32 Drop. Already has a type defined. > + maximum: 32 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - "img,cr-periph" > + - "img,max-burst-multiplier" Don't need quotes. > + - "#dma-cells" > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/mips-gic.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + mdc: dma-controller@18143000 { Drop 'mdc' > + compatible = "img,pistachio-mdc-dma"; > + reg = <0x18143000 0x1000>; > + interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SHARED 28 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&system_clk>; > + clock-names = "sys"; > + > + img,max-burst-multiplier = <16>; > + img,cr-periph = <&cr_periph>; > + > + #dma-cells = <3>; > + }; > -- > 2.43.0 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: dma: img-mdc-dma: convert to DT schema 2025-08-22 19:50 ` Rob Herring @ 2025-08-24 18:55 ` Nino Zhang 0 siblings, 0 replies; 5+ messages in thread From: Nino Zhang @ 2025-08-24 18:55 UTC (permalink / raw) To: robh, krzk+dt Cc: conor+dt, devicetree, dmaengine, linux-kernel, vkoul, rahulbedarkar89, linux-mips On Fri, 22 Aug 2025 14:50:24 -0500 Rob Herring wrote: > > Convert the img-mdc-dma binding from txt to YAML schema. > > No functional changes except dropping the consumer node > > (spi@18100f00) from the example, which belongs to the > > consumer binding instead. > > > > Tested with 'make dt_binding_check'. > > No need to say that in the commit msg. It is assumed you did this. > > > > > Signed-off-by: Nino Zhang <ninozhang001@gmail.com> > > --- > > .../devicetree/bindings/dma/img-mdc-dma.txt | 57 ----------- > > .../devicetree/bindings/dma/img-mdc-dma.yaml | 98 +++++++++++++++++++ > > 2 files changed, 98 insertions(+), 57 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/dma/img-mdc-dma.txt > > create mode 100644 Documentation/devicetree/bindings/dma/img-mdc-dma.yaml > > > > diff --git a/Documentation/devicetree/bindings/dma/img-mdc-dma.txt b/Documentation/devicetree/bindings/dma/img-mdc-dma.txt > > deleted file mode 100644 > > index 28c1341db346..000000000000 > > --- a/Documentation/devicetree/bindings/dma/img-mdc-dma.txt > > +++ /dev/null > > @@ -1,57 +0,0 @@ > > -* IMG Multi-threaded DMA Controller (MDC) > > - > > -Required properties: > > -- compatible: Must be "img,pistachio-mdc-dma". > > -- reg: Must contain the base address and length of the MDC registers. > > -- interrupts: Must contain all the per-channel DMA interrupts. > > -- clocks: Must contain an entry for each entry in clock-names. > > - See ../clock/clock-bindings.txt for details. > > -- clock-names: Must include the following entries: > > - - sys: MDC system interface clock. > > -- img,cr-periph: Must contain a phandle to the peripheral control syscon > > - node which contains the DMA request to channel mapping registers. > > -- img,max-burst-multiplier: Must be the maximum supported burst size multiplier. > > - The maximum burst size is this value multiplied by the hardware-reported bus > > - width. > > -- #dma-cells: Must be 3: > > - - The first cell is the peripheral's DMA request line. > > - - The second cell is a bitmap specifying to which channels the DMA request > > - line may be mapped (i.e. bit N set indicates channel N is usable). > > - - The third cell is the thread ID to be used by the channel. > > - > > -Optional properties: > > -- dma-channels: Number of supported DMA channels, up to 32. If not specified > > - the number reported by the hardware is used. > > - > > -Example: > > - > > -mdc: dma-controller@18143000 { > > - compatible = "img,pistachio-mdc-dma"; > > - reg = <0x18143000 0x1000>; > > - interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>, > > - <GIC_SHARED 28 IRQ_TYPE_LEVEL_HIGH>, > > - <GIC_SHARED 29 IRQ_TYPE_LEVEL_HIGH>, > > - <GIC_SHARED 30 IRQ_TYPE_LEVEL_HIGH>, > > - <GIC_SHARED 31 IRQ_TYPE_LEVEL_HIGH>, > > - <GIC_SHARED 32 IRQ_TYPE_LEVEL_HIGH>, > > - <GIC_SHARED 33 IRQ_TYPE_LEVEL_HIGH>, > > - <GIC_SHARED 34 IRQ_TYPE_LEVEL_HIGH>, > > - <GIC_SHARED 35 IRQ_TYPE_LEVEL_HIGH>, > > - <GIC_SHARED 36 IRQ_TYPE_LEVEL_HIGH>, > > - <GIC_SHARED 37 IRQ_TYPE_LEVEL_HIGH>, > > - <GIC_SHARED 38 IRQ_TYPE_LEVEL_HIGH>; > > - clocks = <&system_clk>; > > - clock-names = "sys"; > > - > > - img,max-burst-multiplier = <16>; > > - img,cr-periph = <&cr_periph>; > > - > > - #dma-cells = <3>; > > -}; > > - > > -spi@18100f00 { > > - ... > > - dmas = <&mdc 9 0xffffffff 0>, <&mdc 10 0xffffffff 0>; > > - dma-names = "tx", "rx"; > > - ... > > -}; > > diff --git a/Documentation/devicetree/bindings/dma/img-mdc-dma.yaml b/Documentation/devicetree/bindings/dma/img-mdc-dma.yaml > > new file mode 100644 > > index 000000000000..b635125d7ae3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/dma/img-mdc-dma.yaml > > Use the compatible string for the filename. > > > @@ -0,0 +1,98 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/dma/img-mdc-dma.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: IMG Multi-threaded DMA Controller (MDC) > > + > > +maintainers: > > + - Vinod Koul <vkoul@kernel.org> > > No, must be someone with this h/w and cares about this h/w. > > > + > > +allOf: > > + - $ref: /schemas/dma/dma-controller.yaml# > > + > > +properties: > > + compatible: > > + description: Must be "img,pistachio-mdc-dma". > > Drop. The schema says that. Same goes for all the other descriptions, so > I won't repeat it everywhere. > > > + const: img,pistachio-mdc-dma > > + > > + reg: > > + description: > > + Must contain the base address and length of the MDC registers. > > Drop. > > > + minItems: 1 > > maxItems instead. > > > + > > + interrupts: > > + description: > > + Must contain all the per-channel DMA interrupts. > > Must define how many. > > > + > > + clocks: > > + description: | > > + Must contain an entry for each entry in clock-names. > > + See clock/clock.yaml for details. > > Drop. > > Must define how many clocks and what they are. > > > + > > + clock-names: > > + description: | > > + Must include the following entries: > > + - sys: MDC system interface clock. > > Drop. The schema says that. > > > + minItems: 1 > > + contains: { const: sys } > > Must be exact list of values, not 'sys' plus anything else you want. > > > + > > + img,cr-periph: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: | > > Drop '|'. Not needed if no formatting to maintain. > > > > + Must contain a phandle to the peripheral control syscon node > > + which contains the DMA request to channel mapping registers. > > + > > + img,max-burst-multiplier: > > + description: | > > + Must be the maximum supported burst size multiplier. > > + The maximum burst size is this value multiplied by the > > + hardware-reported bus width. > > Wrap lines at 80 and drop '|'. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > constraints? > > > + > > + "#dma-cells": > > + description: | > > + Must be 3: > > + - The first cell is the peripheral's DMA request line. > > + - The second cell is a bitmap specifying to which channels the DMA request > > + line may be mapped (i.e. bit N set indicates channel N is usable). > > + - The third cell is the thread ID to be used by the channel. > > + const: 3 > > + > > + dma-channels: > > + description: | > > + Number of supported DMA channels, up to 32. If not specified > > + the number reported by the hardware is used. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > Drop. Already has a type defined. > > > + maximum: 32 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + - "img,cr-periph" > > + - "img,max-burst-multiplier" > > Don't need quotes. > > > + - "#dma-cells" > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/mips-gic.h> > > + #include <dt-bindings/interrupt-controller/irq.h> > > + mdc: dma-controller@18143000 { > > Drop 'mdc' > > > + compatible = "img,pistachio-mdc-dma"; > > + reg = <0x18143000 0x1000>; > > + interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SHARED 28 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&system_clk>; > > + clock-names = "sys"; > > + > > + img,max-burst-multiplier = <16>; > > + img,cr-periph = <&cr_periph>; > > + > > + #dma-cells = <3>; > > + }; > > -- > > 2.43.0 > > Hi Rob, Krzysztof, Thanks for your detailed reviews and guidance. As requested, I went back to the previous posting and responded to each comment below. This summarizes what was fixed in v2 and what I will address in v3. --- > > Tested with 'make dt_binding_check'. > > No need to say that in the commit msg. It is assumed you did this. Fixed in v2. Dropped from commit message. --- > > +++ b/Documentation/devicetree/bindings/dma/img-mdc-dma.yaml > > Use the compatible string for the filename. Fixed in v2. --- > > +maintainers: > > + - Vinod Koul <vkoul@kernel.org> > > No, must be someone with this h/w and cares about this h/w. Fixed in v2. Changed to Rahul Bedarkar (Pistachio DT maintainer) + linux-mips list. Andrew Bresticker (original author) seems inactive. I updated to Rahul Bedarkar, who maintains the Pistachio/CI40 DT (which uses this controller), and added linux-mips list so the platform community is notified. --- > > + compatible: > > + description: Must be "img,pistachio-mdc-dma". > > Drop. The schema says that. Same goes for all the other descriptions, so > I won't repeat it everywhere. Fixed in v2. Dropped redundant descriptions. --- > > + reg: > > + description: > > + Must contain the base address and length of the MDC registers. > > Drop. Fixed in v2. Dropped redundant description. --- > > + minItems: 1 > > > maxItems instead. Fixed in v2. Changed to `maxItems: 1`. --- > > + interrupts: > > + description: > > + Must contain all the per-channel DMA interrupts. > > > Must define how many. Fixed in v2. Defined `minItems: 1`, `maxItems: 32`. This matches the hardware max channels (DMA supports up to 32). The original txt said "all per-channel interrupts", so schema now enforces that. --- > > + clocks: > > + description: | > > + Must contain an entry for each entry in clock-names. > > + See clock/clock.yaml for details. > > Drop. > > Must define how many clocks and what they are. Fixed in v2. Set `clocks: maxItems: 1`. --- > > + clock-names: > > + description: | > > + Must include the following entries: > > + - sys: MDC system interface clock. > > Drop. The schema says that. Fixed in v2. Dropped description. --- > > + minItems: 1 > > + contains: { const: sys } > > Must be exact list of values, not 'sys' plus anything else you want. Fixed in v2. Restricted to `sys`. --- > > + img,cr-periph: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: | > > Drop '|'. Not needed if no formatting to maintain. Ack. I mistakenly switched to `>` in v2. Will drop the indicator in v3. --- > > + img,max-burst-multiplier: > > + description: | > > + Must be the maximum supported burst size multiplier. > > + The maximum burst size is this value multiplied by the > > + hardware-reported bus width. > > Wrap lines at 80 and drop '|'. Ack. Will fix in v3. --- > > + $ref: /schemas/types.yaml#/definitions/uint32 > > constraints? Fixed in v2. Kept as uint32 with `minimum: 1` to exclude invalid 0. Actual maximum not confirmed in available docs. Example uses 16; I will add `maximum` once platform maintainers confirm. --- > > + dma-channels: > > + description: | > > + Number of supported DMA channels, up to 32. If not specified > > + the number reported by the hardware is used. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > Drop. Already has a type defined. Ack. Will fix in v3. --- > > +required: > > + - "img,cr-periph" > > + - "img,max-burst-multiplier" > > Don't need quotes. Fixed in v2. Removed quotes. --- > > +examples: > > + mdc: dma-controller@18143000 { > > Drop 'mdc' Fixed in v2. Dropped node label. --- Please let me know if there are any further concerns. Otherwise, I will send [PATCH v3] shortly as a new thread with the remaining fixes. Thanks, Nino ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] dt-bindings: dma: img-mdc-dma: convert to DT schema 2025-08-21 15:02 [PATCH] dt-bindings: dma: img-mdc-dma: convert to DT schema Nino Zhang 2025-08-22 19:50 ` Rob Herring @ 2025-08-24 3:45 ` Nino Zhang 2025-08-24 11:24 ` Krzysztof Kozlowski 1 sibling, 1 reply; 5+ messages in thread From: Nino Zhang @ 2025-08-24 3:45 UTC (permalink / raw) To: devicetree Cc: robh, krzk+dt, conor+dt, vkoul, rahulbedarkar89, linux-mips, dmaengine, linux-kernel, Nino Zhang Convert the img-mdc-dma binding from txt to YAML schema. No functional changes except dropping the consumer node (spi@18100f00) from the example, which belongs to the consumer binding instead. Signed-off-by: Nino Zhang <ninozhang001@gmail.com> --- Changes since v1: - All review comments addressed. Open: - Maintainers: set to Rahul Bedarkar + linux-mips per MAINTAINERS entry for Pistachio/CI40 device tree. This seems the closest match to the hardware. Happy to adjust if platform maintainers suggest otherwise. - img,max-burst-multiplier: defined as uint32. A minimum of 1 is used to exclude the invalid case of 0, but the actual supported range has not been confirmed in available documentation. Example uses 16. A maximum will be added once confirmed by platform maintainers or hardware docs. .../bindings/dma/img,pistachio-mdc-dma.yaml | 90 +++++++++++++++++++ .../devicetree/bindings/dma/img-mdc-dma.txt | 57 ------------ 2 files changed, 90 insertions(+), 57 deletions(-) create mode 100644 Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml delete mode 100644 Documentation/devicetree/bindings/dma/img-mdc-dma.txt diff --git a/Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml b/Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml new file mode 100644 index 000000000000..4dde54a17f52 --- /dev/null +++ b/Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml @@ -0,0 +1,90 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/dma/img,pistachio-mdc-dma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: IMG Multi-threaded DMA Controller (MDC) + +maintainers: + - Rahul Bedarkar <rahulbedarkar89@gmail.com> + - linux-mips@vger.kernel.org + +allOf: + - $ref: /schemas/dma/dma-controller.yaml# + +properties: + compatible: + const: img,pistachio-mdc-dma + + reg: + maxItems: 1 + + interrupts: + minItems: 1 + maxItems: 32 + + clocks: + maxItems: 1 + + clock-names: + items: + - const: sys + + img,cr-periph: + $ref: /schemas/types.yaml#/definitions/phandle + description: > + Phandle to peripheral control syscon node with DMA request to channel + mapping registers. + + img,max-burst-multiplier: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 1 + description: > + Maximum supported burst size multiplier. The maximum burst size is this + value multiplied by the hardware-reported bus width. + + "#dma-cells": + const: 3 + description: | + DMA specifier cells: + 1: peripheral's DMA request line + 2: channel bitmap: bit N set indicates channel N is usable + 3: thread ID to be used by the channel + + dma-channels: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 1 + maximum: 32 + description: Number of supported DMA channels (defaults to HW-reported value) + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + - img,cr-periph + - img,max-burst-multiplier + - "#dma-cells" + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/mips-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + + dma-controller@18143000 { + compatible = "img,pistachio-mdc-dma"; + reg = <0x18143000 0x1000>; + interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SHARED 28 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&system_clk>; + clock-names = "sys"; + + img,max-burst-multiplier = <16>; + img,cr-periph = <&cr_periph>; + + #dma-cells = <3>; + }; diff --git a/Documentation/devicetree/bindings/dma/img-mdc-dma.txt b/Documentation/devicetree/bindings/dma/img-mdc-dma.txt deleted file mode 100644 index 28c1341db346..000000000000 --- a/Documentation/devicetree/bindings/dma/img-mdc-dma.txt +++ /dev/null @@ -1,57 +0,0 @@ -* IMG Multi-threaded DMA Controller (MDC) - -Required properties: -- compatible: Must be "img,pistachio-mdc-dma". -- reg: Must contain the base address and length of the MDC registers. -- interrupts: Must contain all the per-channel DMA interrupts. -- clocks: Must contain an entry for each entry in clock-names. - See ../clock/clock-bindings.txt for details. -- clock-names: Must include the following entries: - - sys: MDC system interface clock. -- img,cr-periph: Must contain a phandle to the peripheral control syscon - node which contains the DMA request to channel mapping registers. -- img,max-burst-multiplier: Must be the maximum supported burst size multiplier. - The maximum burst size is this value multiplied by the hardware-reported bus - width. -- #dma-cells: Must be 3: - - The first cell is the peripheral's DMA request line. - - The second cell is a bitmap specifying to which channels the DMA request - line may be mapped (i.e. bit N set indicates channel N is usable). - - The third cell is the thread ID to be used by the channel. - -Optional properties: -- dma-channels: Number of supported DMA channels, up to 32. If not specified - the number reported by the hardware is used. - -Example: - -mdc: dma-controller@18143000 { - compatible = "img,pistachio-mdc-dma"; - reg = <0x18143000 0x1000>; - interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 28 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 29 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 30 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 31 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 32 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 33 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 34 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 35 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 36 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 37 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SHARED 38 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&system_clk>; - clock-names = "sys"; - - img,max-burst-multiplier = <16>; - img,cr-periph = <&cr_periph>; - - #dma-cells = <3>; -}; - -spi@18100f00 { - ... - dmas = <&mdc 9 0xffffffff 0>, <&mdc 10 0xffffffff 0>; - dma-names = "tx", "rx"; - ... -}; -- 2.43.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: dma: img-mdc-dma: convert to DT schema 2025-08-24 3:45 ` [PATCH v2] " Nino Zhang @ 2025-08-24 11:24 ` Krzysztof Kozlowski 0 siblings, 0 replies; 5+ messages in thread From: Krzysztof Kozlowski @ 2025-08-24 11:24 UTC (permalink / raw) To: Nino Zhang, devicetree Cc: robh, krzk+dt, conor+dt, vkoul, rahulbedarkar89, linux-mips, dmaengine, linux-kernel On 24/08/2025 05:45, Nino Zhang wrote: > Convert the img-mdc-dma binding from txt to YAML schema. > No functional changes except dropping the consumer node > (spi@18100f00) from the example, which belongs to the > consumer binding instead. > > Signed-off-by: Nino Zhang <ninozhang001@gmail.com> > --- > Changes since v1: > - All review comments addressed. Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets. > > Open: > - Maintainers: set to Rahul Bedarkar + linux-mips per MAINTAINERS entry > for Pistachio/CI40 device tree. This seems the closest match to the > hardware. Happy to adjust if platform maintainers suggest otherwise. > - img,max-burst-multiplier: defined as uint32. A minimum of 1 is used to > exclude the invalid case of 0, but the actual supported range has not > been confirmed in available documentation. Example uses 16. A maximum > will be added once confirmed by platform maintainers or hardware docs. > > .../bindings/dma/img,pistachio-mdc-dma.yaml | 90 +++++++++++++++++++ > .../devicetree/bindings/dma/img-mdc-dma.txt | 57 ------------ > 2 files changed, 90 insertions(+), 57 deletions(-) > create mode 100644 Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml > delete mode 100644 Documentation/devicetree/bindings/dma/img-mdc-dma.txt > > diff --git a/Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml b/Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml > new file mode 100644 > index 000000000000..4dde54a17f52 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml > @@ -0,0 +1,90 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/img,pistachio-mdc-dma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: IMG Multi-threaded DMA Controller (MDC) > + > +maintainers: > + - Rahul Bedarkar <rahulbedarkar89@gmail.com> > + - linux-mips@vger.kernel.org > + > +allOf: > + - $ref: /schemas/dma/dma-controller.yaml# > + > +properties: > + compatible: > + const: img,pistachio-mdc-dma > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 1 > + maxItems: 32 Why is this flexible? > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: sys > + > + img,cr-periph: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > Drop > You already got exactly the same comment. > + Phandle to peripheral control syscon node with DMA request to channel > + mapping registers. > + > + img,max-burst-multiplier: > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 Does not feel like enough of constraints. > + description: > > + Maximum supported burst size multiplier. The maximum burst size is this > + value multiplied by the hardware-reported bus width. > + > + "#dma-cells": > + const: 3 > + description: | > + DMA specifier cells: > + 1: peripheral's DMA request line > + 2: channel bitmap: bit N set indicates channel N is usable > + 3: thread ID to be used by the channel > + > + dma-channels: > + $ref: /schemas/types.yaml#/definitions/uint32 More ignored comments. Please go back to previous posting and respond to each comment. Then implement each one or keep discussing. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-08-24 18:55 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-08-21 15:02 [PATCH] dt-bindings: dma: img-mdc-dma: convert to DT schema Nino Zhang 2025-08-22 19:50 ` Rob Herring 2025-08-24 18:55 ` Nino Zhang 2025-08-24 3:45 ` [PATCH v2] " Nino Zhang 2025-08-24 11:24 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).