From: "guomengqi (A)" <guomengqi3@huawei.com>
To: Rob Herring <robh@kernel.org>
Cc: <vkoul@kernel.org>, <devicetree@vger.kernel.org>,
<xuqiang36@huawei.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <dmaengine@vger.kernel.org>,
<chenweilong@huawei.com>, <conor+dt@kernel.org>
Subject: Re: [PATCH v5 2/2] dt-bindings: dma: HiSilicon: Add bindings for HiSilicon Ascend sdma
Date: Tue, 24 Oct 2023 10:04:20 +0800 [thread overview]
Message-ID: <c2803495-691d-9e3f-5012-1df13c32332c@huawei.com> (raw)
In-Reply-To: <169788348856.1320467.2316881090457833857.robh@kernel.org>
在 2023/10/21 18:18, Rob Herring 写道:
> On Sat, 21 Oct 2023 17:34:53 +0800, Guo Mengqi wrote:
>> Add device-tree binding documentation for sdma hardware on
>> HiSilicon Ascend SoC families.
>>
>> Signed-off-by: Guo Mengqi <guomengqi3@huawei.com>
>> ---
>> .../bindings/dma/hisilicon,ascend-sdma.yaml | 73 +++++++++++++++++++
>> 1 file changed, 73 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/dma/hisilicon,ascend-sdma.yaml
>>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/hisilicon,ascend-sdma.yaml: dma-can-stall: missing type definition
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231021093454.39822-3-guomengqi3@huawei.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
>
> .
It seems "pip3 install dtschema --upgrade" does not work for me. I use
git clone to get the correct validator.py.
'dma-can-stall' is not a vendor specific property.
Shall I state the missing type definition in my binding or elsewhere?
next prev parent reply other threads:[~2023-10-24 2:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 9:34 [PATCH v5 0/2] Add dma controller driver for HiSilicon Ascend310/910 Guo Mengqi
2023-10-21 9:34 ` [PATCH v5 1/2] dmaengine: Add HiSilicon Ascend SDMA engine support Guo Mengqi
2023-10-24 18:43 ` kernel test robot
2023-10-24 20:10 ` kernel test robot
2023-10-21 9:34 ` [PATCH v5 2/2] dt-bindings: dma: HiSilicon: Add bindings for HiSilicon Ascend sdma Guo Mengqi
2023-10-21 10:18 ` Rob Herring
2023-10-24 2:04 ` guomengqi (A) [this message]
2023-10-22 21:13 ` Rob Herring
2023-10-23 9:08 ` guomengqi (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2803495-691d-9e3f-5012-1df13c32332c@huawei.com \
--to=guomengqi3@huawei.com \
--cc=chenweilong@huawei.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=xuqiang36@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox