DMA Engine development
 help / color / mirror / Atom feed
From: "Ardelean, Alexandru" <Alex.Ardelean@analog.com>
To: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"vkoul@kernel.org" <vkoul@kernel.org>
Subject: [V2] dmaengine: axi-dmac: assign `copy_align` property
Date: Wed, 27 Feb 2019 08:12:45 +0000	[thread overview]
Message-ID: <c6f44ad7dd90350f4f45fe3efa2117f7c0f0757f.camel@analog.com> (raw)

On Tue, 2019-02-26 at 10:52 +0200, Alexandru Ardelean wrote:
> The `copy_align` property is a generic property that describes alignment
> for DMA memcpy & sg ops.
> It serves mostly an informational purpose, and can be used in DMA tests,
> to
> pass the info to know what alignment to expect.
> 

build bot said this doesn't compile.
I think this patch needs to come later after some more updates have been
pushed for this driver.

> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> ---
> 
> Changelog v1 -> v2:
> * re-applied & moved the `copy_align` assignment; apparently it was
>   conflicting with another patch from another series
> 
>  drivers/dma/dma-axi-dmac.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index ffc0adc2f6ce..5ec223ff7e1a 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -666,6 +666,7 @@ static int axi_dmac_probe(struct platform_device
> *pdev)
>  	dma_dev->dst_addr_widths = BIT(dmac->chan.dest_width);
>  	dma_dev->directions = BIT(dmac->chan.direction);
>  	dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_DESCRIPTOR;
> +	dma_dev->copy_align = (dmac->chan.address_align_mask + 1);
>  	INIT_LIST_HEAD(&dma_dev->channels);
>  
>  	dmac->chan.vchan.desc_free = axi_dmac_desc_free;

             reply	other threads:[~2019-02-27  8:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-27  8:12 Ardelean, Alexandru [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-02-27 10:55 [V2] dmaengine: axi-dmac: assign `copy_align` property Vinod Koul
2019-02-26 17:43 kbuild test robot
2019-02-26  8:52 Alexandru Ardelean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6f44ad7dd90350f4f45fe3efa2117f7c0f0757f.camel@analog.com \
    --to=alex.ardelean@analog.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox