* [PATCH 1/3] dt-bindings: mtd: cdns,hp-nfc: Add iommu property
2025-10-13 1:06 [PATCH 0/3] Add iommu supports Khairul Anuar Romli
@ 2025-10-13 1:06 ` Khairul Anuar Romli
2025-10-13 1:09 ` Krzysztof Kozlowski
2025-10-13 1:06 ` [PATCH 2/3] dt-bindings: dma: snps,dw-axi-dmac: " Khairul Anuar Romli
2025-10-13 1:06 ` [PATCH 3/3] arm64: dts: socfpga: agilex5: Add SMMU nodes Khairul Anuar Romli
2 siblings, 1 reply; 5+ messages in thread
From: Khairul Anuar Romli @ 2025-10-13 1:06 UTC (permalink / raw)
To: Eugeniy Paltsev, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Niravkumar L Rabara, open list:CADENCE NAND DRIVER, Dinh Nguyen,
Khairul Anuar Romli, Adrian Ng Ho Yin
Add iommu as an optional property that can be added to the cdns,hp-nfc
compatible node.
Signed-off-by: Adrian Ng Ho Yin <adrianhoyin.ng@altera.com>
Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
---
Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml b/Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml
index e1f4d7c35a88..73dc69cee4d8 100644
--- a/Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml
+++ b/Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml
@@ -40,6 +40,9 @@ properties:
dmas:
maxItems: 1
+ iommus:
+ maxItems: 1
+
cdns,board-delay-ps:
description: |
Estimated Board delay. The value includes the total round trip
--
2.35.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/3] dt-bindings: mtd: cdns,hp-nfc: Add iommu property
2025-10-13 1:06 ` [PATCH 1/3] dt-bindings: mtd: cdns,hp-nfc: Add iommu property Khairul Anuar Romli
@ 2025-10-13 1:09 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-13 1:09 UTC (permalink / raw)
To: Khairul Anuar Romli, Eugeniy Paltsev, Vinod Koul, Rob Herring,
Krzysztof Kozlowski, Conor Dooley,
open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Niravkumar L Rabara, open list:CADENCE NAND DRIVER, Dinh Nguyen,
Adrian Ng Ho Yin
On 13/10/2025 03:06, Khairul Anuar Romli wrote:
> Add iommu as an optional property that can be added to the cdns,hp-nfc
> compatible node.
We see this from the diff, you said nothing new. Don't describe what the
patch does, but say why, describe hardware. This message is completely
redundant and non-informative.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/3] dt-bindings: dma: snps,dw-axi-dmac: Add iommu property
2025-10-13 1:06 [PATCH 0/3] Add iommu supports Khairul Anuar Romli
2025-10-13 1:06 ` [PATCH 1/3] dt-bindings: mtd: cdns,hp-nfc: Add iommu property Khairul Anuar Romli
@ 2025-10-13 1:06 ` Khairul Anuar Romli
2025-10-13 1:06 ` [PATCH 3/3] arm64: dts: socfpga: agilex5: Add SMMU nodes Khairul Anuar Romli
2 siblings, 0 replies; 5+ messages in thread
From: Khairul Anuar Romli @ 2025-10-13 1:06 UTC (permalink / raw)
To: Eugeniy Paltsev, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Niravkumar L Rabara, open list:CADENCE NAND DRIVER, Dinh Nguyen,
Khairul Anuar Romli, Adrian Ng Ho Yin
Add iommu as an optional property that can be added to the snps,dw-axi-dmac
compatible node.
Signed-off-by: Adrian Ng Ho Yin <adrianhoyin.ng@altera.com>
Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
---
Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
index 935735a59afd..a393a33c8908 100644
--- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
+++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
@@ -42,6 +42,9 @@ properties:
minItems: 1
maxItems: 8
+ iommus:
+ maxItems: 1
+
clocks:
items:
- description: Bus Clock
--
2.35.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 3/3] arm64: dts: socfpga: agilex5: Add SMMU nodes
2025-10-13 1:06 [PATCH 0/3] Add iommu supports Khairul Anuar Romli
2025-10-13 1:06 ` [PATCH 1/3] dt-bindings: mtd: cdns,hp-nfc: Add iommu property Khairul Anuar Romli
2025-10-13 1:06 ` [PATCH 2/3] dt-bindings: dma: snps,dw-axi-dmac: " Khairul Anuar Romli
@ 2025-10-13 1:06 ` Khairul Anuar Romli
2 siblings, 0 replies; 5+ messages in thread
From: Khairul Anuar Romli @ 2025-10-13 1:06 UTC (permalink / raw)
To: Eugeniy Paltsev, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Niravkumar L Rabara, open list:CADENCE NAND DRIVER, Dinh Nguyen,
Khairul Anuar Romli, Adrian Ng Ho Yin
Add SMMU nodes for Agilex5. This SMMU nodes is compatible with arm,smmu-v3.
Add IOMMU property to the supported nodes.
- nand-controller
- dma-controller 0 and dma-controller 1
- usb
Signed-off-by: Adrian Ng Ho Yin <adrianhoyin.ng@altera.com>
Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
---
arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
index 04e99cd7e74b..a22cf6a211e2 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
@@ -272,6 +272,7 @@ nand: nand-controller@10b80000 {
interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clkmgr AGILEX5_NAND_NF_CLK>;
cdns,board-delay-ps = <4830>;
+ iommus = <&smmu 4>;
status = "disabled";
};
@@ -298,6 +299,7 @@ dmac0: dma-controller@10db0000 {
snps,block-size = <32767 32767 32767 32767>;
snps,priority = <0 1 2 3>;
snps,axi-max-burst-len = <8>;
+ iommus = <&smmu 8>;
};
dmac1: dma-controller@10dc0000 {
@@ -315,6 +317,7 @@ dmac1: dma-controller@10dc0000 {
snps,block-size = <32767 32767 32767 32767>;
snps,priority = <0 1 2 3>;
snps,axi-max-burst-len = <8>;
+ iommus = <&smmu 9>;
};
rst: rstmgr@10d11000 {
@@ -323,6 +326,18 @@ rst: rstmgr@10d11000 {
#reset-cells = <1>;
};
+ smmu: iommu@16000000 {
+ compatible = "arm,smmu-v3";
+ reg = <0x16000000 0x30000>;
+ interrupts = <GIC_SPI 134 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 129 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 132 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "eventq", "gerror", "priq";
+ dma-coherent;
+ #iommu-cells = <1>;
+ status = "disabled";
+ };
+
spi0: spi@10da4000 {
compatible = "snps,dw-apb-ssi";
reg = <0x10da4000 0x1000>;
@@ -423,6 +438,7 @@ usb0: usb@10b00000 {
phy-names = "usb2-phy";
resets = <&rst USB0_RESET>, <&rst USB0_OCP_RESET>;
reset-names = "dwc2", "dwc2-ecc";
+ iommus = <&smmu 6>;
clocks = <&clkmgr AGILEX5_USB2OTG_HCLK>;
clock-names = "otg";
status = "disabled";
--
2.35.3
^ permalink raw reply related [flat|nested] 5+ messages in thread