From: "Ardelean, Alexandru" <Alex.Ardelean@analog.com>
To: "lkp@intel.com" <lkp@intel.com>
Cc: "kbuild-all@01.org" <kbuild-all@01.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>
Subject: dma: axi-dmac: Split too large segments
Date: Mon, 18 Feb 2019 07:28:03 +0000 [thread overview]
Message-ID: <d7b4957e2e0c626fe3e426f74fbd38c5be35aff0.camel@analog.com> (raw)
On Sat, 2019-02-16 at 17:03 +0800, kbuild test robot wrote:
>
My bad here.
I took this patch from our kernel tree and sent it.
I assumed it works, since it works in our tree.
I'll take a look and see about the order of patches, and which one(s)
need(s) to be sent before this one
Thanks
Alex
>
> Hi Lars-Peter,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v5.0-rc4 next-20190215]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Alexandru-Ardelean/dma-axi-dmac-Split-too-large-segments/20190216-160002
> config: nds32-allyesconfig (attached as .config)
> compiler: nds32le-linux-gcc (GCC) 6.4.0
> reproduce:
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> GCC_VERSION=6.4.0 make.cross ARCH=nds32
>
> All errors (new ones prefixed by >>):
>
> drivers//dma/dma-axi-dmac.c: In function 'axi_dmac_prep_slave_sg':
> > > drivers//dma/dma-axi-dmac.c:443:12: error: implicit declaration of
> > > function 'sg_nents_for_dma' [-Werror=implicit-function-declaration]
>
> num_sgs = sg_nents_for_dma(sgl, sg_len, chan->max_length);
> ^~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> vim +/sg_nents_for_dma +443 drivers//dma/dma-axi-dmac.c
>
> 427
> 428 static struct dma_async_tx_descriptor *axi_dmac_prep_slave_sg(
> 429 struct dma_chan *c, struct scatterlist *sgl,
> 430 unsigned int sg_len, enum dma_transfer_direction
> direction,
> 431 unsigned long flags, void *context)
> 432 {
> 433 struct axi_dmac_chan *chan = to_axi_dmac_chan(c);
> 434 struct axi_dmac_desc *desc;
> 435 struct axi_dmac_sg *dsg;
> 436 struct scatterlist *sg;
> 437 unsigned int num_sgs;
> 438 unsigned int i;
> 439
> 440 if (direction != chan->direction)
> 441 return NULL;
> 442
> > 443 num_sgs = sg_nents_for_dma(sgl, sg_len, chan-
> >max_length);
> 444 desc = axi_dmac_alloc_desc(num_sgs);
> 445 if (!desc)
> 446 return NULL;
> 447
> 448 dsg = desc->sg;
> 449
> 450 for_each_sg(sgl, sg, sg_len, i) {
> 451 if (!axi_dmac_check_addr(chan,
> sg_dma_address(sg)) ||
> 452 !axi_dmac_check_len(chan, sg_dma_len(sg))) {
> 453 kfree(desc);
> 454 return NULL;
> 455 }
> 456
> 457 dsg = axi_dmac_fill_linear_sg(chan, direction,
> sg_dma_address(sg), 1,
> 458 sg_dma_len(sg), dsg);
> 459 }
> 460
> 461 desc->cyclic = false;
> 462
> 463 return vchan_tx_prep(&chan->vchan, &desc->vdesc, flags);
> 464 }
> 465
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology
> Center
> https://lists.01.org/pipermail/kbuild-all Intel
> Corporation
next reply other threads:[~2019-02-18 7:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 7:28 Ardelean, Alexandru [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-25 6:56 dma: axi-dmac: Split too large segments Vinod Koul
2019-02-18 7:34 Lars-Peter Clausen
2019-02-16 10:08 kbuild test robot
2019-02-15 11:06 Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7b4957e2e0c626fe3e426f74fbd38c5be35aff0.camel@analog.com \
--to=alex.ardelean@analog.com \
--cc=dmaengine@vger.kernel.org \
--cc=kbuild-all@01.org \
--cc=lars@metafoo.de \
--cc=lkp@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox