DMA Engine development
 help / color / mirror / Atom feed
From: "Ardelean, Alexandru" <Alex.Ardelean@analog.com>
To: "vkoul@kernel.org" <vkoul@kernel.org>
Cc: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"Bogdan, Dragos" <Dragos.Bogdan@analog.com>
Subject: [2/2] dma: axi-dmac: report DMA_INTERLEAVE capability
Date: Tue, 26 Feb 2019 07:15:52 +0000	[thread overview]
Message-ID: <e76d972db2b6b466d862f9ec51325ca9849490e6.camel@analog.com> (raw)

On Mon, 2019-02-25 at 12:23 +0530, Vinod Koul wrote:
> [External]
> 
> 
> On 15-02-19, 11:17, Alexandru Ardelean wrote:
> > From: Dragos Bogdan <dragos.bogdan@analog.com>
> > 
> > Fixes commit 0e3b67b348b8 ("dmaengine: Add support for the Analog
> > Devices
> > AXI-DMAC DMA controller")
> 
> Am not sire this is appropriate here..
> 

Hmm, probably.
I'm a bit vague if a device_prep_interleaved_dma() callback works fine [or
is fine to have] without a DMA_INTERLEAVE flag in the caps. I did not dig
too deep into the dmaengine.

I can re-spin this without the Fixes stuff

> > 
> > The `device_prep_interleaved_dma()` callback is already present since
> > the
> > driver was submitted initially.
> > This change adds the DMA_INTERLEAVE capability to the capability mask
> > of
> > the DMA engine.
> > 
> > Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> > ---
> >  drivers/dma/dma-axi-dmac.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> > index 2c999113b989..b2039e60ae04 100644
> > --- a/drivers/dma/dma-axi-dmac.c
> > +++ b/drivers/dma/dma-axi-dmac.c
> > @@ -652,6 +652,7 @@ static int axi_dmac_probe(struct platform_device
> > *pdev)
> >       dma_dev = &dmac->dma_dev;
> >       dma_cap_set(DMA_SLAVE, dma_dev->cap_mask);
> >       dma_cap_set(DMA_CYCLIC, dma_dev->cap_mask);
> > +     dma_cap_set(DMA_INTERLEAVE, dma_dev->cap_mask);
> >       dma_dev->device_free_chan_resources =
> > axi_dmac_free_chan_resources;
> >       dma_dev->device_tx_status = dma_cookie_status;
> >       dma_dev->device_issue_pending = axi_dmac_issue_pending;
> > --
> > 2.17.1
> 
> --
> ~Vinod

             reply	other threads:[~2019-02-26  7:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-26  7:15 Ardelean, Alexandru [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-02-26  8:02 [2/2] dma: axi-dmac: report DMA_INTERLEAVE capability Vinod Koul
2019-02-25  6:53 Vinod Koul
2019-02-15  9:17 Alexandru Ardelean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e76d972db2b6b466d862f9ec51325ca9849490e6.camel@analog.com \
    --to=alex.ardelean@analog.com \
    --cc=Dragos.Bogdan@analog.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox