From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BD854596B for ; Fri, 17 May 2024 23:13:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715987594; cv=none; b=To9Cd0s14UxwFijar1P47qf9xhET939gwKEK3RI9ZobaJGQnmivWxc/J72HSgVFuT//7Uk4gmE71Ql7Tc4zZhJ0xX29q0qbwofze4eatEqooJNA6spLD4KS0wkgxhDUOpLh1aqsEDfHVTtKbstBQFfl4jyDSsIS9aqQCluUEwHo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715987594; c=relaxed/simple; bh=E6xXHE2U0UNNqbgVzCG9WXRjb+Eb3Yuxe05NpCER5NI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PJk/hdX0i1OXHrvUM6JMXk7F9JOcLl5hSkX+CQ56wLhqi88jtH47j+fzMO1P8SvoZYVZPkSjrPsUF7QPsFrLtTPEUWFTKnGrzu0Wrslku6XUqQgvz4DYSa9Y7zHqOrSTsSDyO6FwHZNDIiC30bjvCVxD5exqzK8KsHOKmH+TnpI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ytc/4XLt; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ytc/4XLt" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-420160f8f52so6537365e9.0 for ; Fri, 17 May 2024 16:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715987591; x=1716592391; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TZVI66jI2kN4mSZo36o1UAonrQfJPzrUsip59CjO1Ds=; b=Ytc/4XLtMqWzVg+ic28qgBCB4R9/50yX3QHIDcRotmrwDdoAcq+iw9hSRCVQH0dejk vs9UfcNWKnimQMAkWoL3Z2hOhsiGoXlPihkh9ezApuK6+WmqrO5eAtRw5kLI4dOiNUqU SQfpij3DLxmceCQL+abseWqtKmRZZLW1SzV5p68M+/Qq3oo1r2QMON9hdguNwxyyOavd vsGjiREsjUqmenB4g7l0Y289NDC4TJ0L361uPFmvl4tV7lZa2NAFHlYAoqYUuipsRE8R dbm4FVgcszFTuAEKuUBSqg0wXll8Wbs8dMXhAyQpRSouFigD+Ty+pOly3JVm588kaRf1 8ltg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715987591; x=1716592391; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TZVI66jI2kN4mSZo36o1UAonrQfJPzrUsip59CjO1Ds=; b=a+9Lu9DOXD7I0V4OuvItK7HUHZvCUNCNaIRD3Gjn4mz2Ts/mI1fyt9ll63X09IxyIz CWE3Xldq4CiNKY73GkVUWHVcfOecvvxhQkqnrH5aC2STLPrW+Y2iD8npu51o+z5VZlFa p+q+NqiypMroScdt6SPntVQIPUiYo5dwyUiiwA/YeENj1EDJRJbJ70hhO4beV9+95Ih1 zPSZMnX19ZnDaGqwcIbtjxX/ByYdYytMLO497xSvGpzOPtE/aAvlWFCx8SZqRXM2+cpG LZR/Pphvek9Pzh8l6MmMzOvgf2/tbh4/SmksQw03bCAH0Lby7IFTPzTnQQK6INVL12f4 JwRA== X-Forwarded-Encrypted: i=1; AJvYcCXAS70ABYrCgkd59uAMfdE72cfS84RHAzgtirz3vET3WGrDEjqoYSUCa9u44yVbFUuox/pRbBpyiNRsAbrt4dPM5J+jPrGEFlOO X-Gm-Message-State: AOJu0YzvyosUPOKIFmxSVy3ZFlLFod11bVhIRY9XA5QW2kqMCSW3XQg3 z432erC0b0+lyYpG9Iktd6g/VDIuxW01AyzgYdv4Mu0/WpcyoFlIi5Zlnv+ML+I= X-Google-Smtp-Source: AGHT+IEBoYAYHc0la+iBnbQ21k30p9u7QPWes2aucTfYwgEf7j3QWhSJ6wWOQA7MBsRGI/TMSuCYXQ== X-Received: by 2002:a05:600c:4751:b0:420:d54:7003 with SMTP id 5b1f17b1804b1-4200d547063mr154691165e9.20.1715987591024; Fri, 17 May 2024 16:13:11 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-41fccce2580sm318368025e9.18.2024.05.17.16.13.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 May 2024 16:13:10 -0700 (PDT) Message-ID: Date: Sat, 18 May 2024 00:13:09 +0100 Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] dmaengine: qcom: gpi: remove unused struct 'reg_info' To: "Dr. David Alan Gilbert" Cc: Frank.li@nxp.com, vkoul@kernel.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240516152537.262354-1-linux@treblig.org> <39b66355-f67e-49e9-a64b-fdd87340f787@linaro.org> <3fe6e86d-5b4d-4b3c-a5d7-59f01dc6b0bc@linaro.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/05/2024 00:04, Dr. David Alan Gilbert wrote: > * Bryan O'Donoghue (bryan.odonoghue@linaro.org) wrote: >> On 17/05/2024 12:19, Dr. David Alan Gilbert wrote: >>>> If you look at the V1 I had >>>> ''gpi_desc' seems like it was never used. >>>> Remove it.' >>>> >>>> but Frank suggested copying the subject line; so I'm not sure >>>> whether you want more or less! >>>> >>>> I could change this to: >>>> >>>> 'gpi_desc' was never used since it's initial >>>> commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver") >>> Oops, of course I mean 'reg_info' which is what I fixed in v2. >>> >>>> Would you be OK with that? >>> Dave >>> >>>> Dave >> >> Hi Dave, >> >> I saw your v1 interaction after commenting but, I still think commits that >> say "this removes a data structure" should elaborate more. >> >> "This structure is no longer used since commit: 12charsubshahere" or "This >> structure was never used and should be considered dead code" >> >> I generally hope the intention of my commits is clear from the code with the >> commit log adding whatever context or elaboration on top. >> >> So that's what I'm suggesting here. A bit of commit log sugar on top which >> elaborates on and justifies the change. > > OK, so how about the version I suggested above: > > 'reg_info' was never used since it's initial > commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver") > Remove it. > > Is that OK with you? > > Dave > >> >> --- >> bod >> LGTM Reviewed-by: Bryan O'Donoghue