RE: [PATCH v19 2/4] dmaengine: tegra: Add tegra gpcdma driver

Akhil R
2022-02-08T17:22:19Z

> 07.02.2022 18:01, Akhil R пишет:
> > Adding GPC DMA controller driver for Tegra. The driver supports dma
> > transfers between memory to memory, IO peripheral to memory and
> > memory to IO peripheral.
> >
> > Co-developed-by: Pavan Kunapuli <pkunapuli@nvidia.com>
> > Signed-off-by: Pavan Kunapuli <pkunapuli@nvidia.com>
> > Co-developed-by: Rajesh Gumasta <rgumasta@nvidia.com>
> > Signed-off-by: Rajesh Gumasta <rgumasta@nvidia.com>
> > Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> > Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
> > ---
> > drivers/dma/Kconfig | 11 +
> > drivers/dma/Makefile | 1 +
> > drivers/dma/tegra186-gpc-dma.c | 1505
> ++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 1517 insertions(+)
> > create mode 100644 drivers/dma/tegra186-gpc-dma.c
>
> Looks okay to me. Thank you for the effort!
>
> Coding style isn't ideal:
>
> - inconsistent alignment of the code
> - unnecessary whitespaces and parens
> - inconsistent variables type signes
> - all abbreviation should be capitalized in comments and commit msg
>
> but this is not critical and could be improved later on.
>
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>

Thanks for the review.

Regards,
Akhil