From: "Nuno Sá" <noname.nuno@gmail.com>
To: David Lechner <dlechner@baylibre.com>,
nuno.sa@analog.com, linux-clk@vger.kernel.org,
linux-fpga@vger.kernel.org, dmaengine@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-spi@vger.kernel.org
Cc: "Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Moritz Fischer" <mdf@kernel.org>, "Wu Hao" <hao.wu@intel.com>,
"Xu Yilun" <yilun.xu@intel.com>, "Tom Rix" <trix@redhat.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Trevor Gamblin" <tgamblin@baylibre.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Mike Turquette" <mturquette@linaro.org>
Subject: Re: [PATCH v4 4/7] include: fpga: adi-axi-common: add new helper macros
Date: Wed, 07 May 2025 07:11:53 +0100 [thread overview]
Message-ID: <ffebef8dd4255da67a8d6b7228f4e04e789532d5.camel@gmail.com> (raw)
In-Reply-To: <79c256ab-3d21-481c-ab9d-eca643d3d998@baylibre.com>
On Mon, 2025-05-05 at 12:21 -0500, David Lechner wrote:
> On 5/5/25 11:41 AM, Nuno Sá via B4 Relay wrote:
> > From: Nuno Sá <nuno.sa@analog.com>
> >
> > Add new helper macros and enums to help identifying the platform and some
> > characteristics of it at runtime.
> >
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
> > include/linux/adi-axi-common.h | 35 +++++++++++++++++++++++++++++++++++
>
> Since this file was moved in the previous patch, should we drop "fpga:" from the
> subject of this patch?
sure
>
> > 1 file changed, 35 insertions(+)
> >
> > diff --git a/include/linux/adi-axi-common.h b/include/linux/adi-axi-common.h
> > index
> > 141ac3f251e6f256526812b9d55cd440a2a46e76..a832ef9b37473ca339a2a2ff8a4a5716d428fd2
> > 9 100644
> > --- a/include/linux/adi-axi-common.h
> > +++ b/include/linux/adi-axi-common.h
> > @@ -12,6 +12,8 @@
> > #define ADI_AXI_COMMON_H_
> >
> > #define ADI_AXI_REG_VERSION 0x0000
> > +#define ADI_AXI_REG_FPGA_INFO 0x001C
> > +#define ADI_AXI_REG_FPGA_VOLTAGE 0x0140
>
> Doesn't the voltage register only apply to AXI CLKGEN and therefore would
> belong in the clock driver rather than here? 0x1C seems to be the last of the
> defined "common to all IP cores" address before we possibly get into
> core-specific register definitions starting at 0x40.
>
> I guess there are 1 or 2 other cores that define it at the same place, but it
> still seems not-global.
Hmm, to be honest I did not checked. This patch was out of tree and I blindly pushed
it (as its straightforward). Will drop the above.
>
> >
> > #define ADI_AXI_PCORE_VER(major, minor, patch) \
> > (((major) << 16) | ((minor) << 8) | (patch))
> > @@ -20,4 +22,37 @@
> > #define ADI_AXI_PCORE_VER_MINOR(version) (((version) >> 8) & 0xff)
> > #define ADI_AXI_PCORE_VER_PATCH(version) ((version) & 0xff)
> >
> > +#define ADI_AXI_INFO_FPGA_TECH(info) (((info) >> 24) & 0xff)
> > +#define ADI_AXI_INFO_FPGA_FAMILY(info) (((info) >> 16) & 0xff)
> > +#define ADI_AXI_INFO_FPGA_SPEED_GRADE(info) (((info) >> 8) & 0xff)
>
> I guess we don't care about the DEV_PACKAGE field?
ack
>
> > +#define ADI_AXI_INFO_FPGA_VOLTAGE(val) ((val) & 0xffff)
>
> This VOLTAGE also goes applies to the first comment.
>
ack
next prev parent reply other threads:[~2025-05-07 7:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 16:41 [PATCH v4 0/7] clk: clk-axi-clkgen: improvements and some fixes Nuno Sá via B4 Relay
2025-05-05 16:41 ` [PATCH v4 1/7] clk: clk-axi-clkgen: fix fpfd_max frequency for zynq Nuno Sá via B4 Relay
2025-05-05 16:41 ` [PATCH v4 2/7] clk: clk-axi-clkgen: make sure to include mod_devicetable.h Nuno Sá via B4 Relay
2025-05-05 16:41 ` [PATCH v4 3/7] include: linux: move adi-axi-common.h out of fpga Nuno Sá via B4 Relay
2025-05-05 18:30 ` Jonathan Cameron
2025-05-07 2:35 ` Xu Yilun
2025-05-05 16:41 ` [PATCH v4 4/7] include: fpga: adi-axi-common: add new helper macros Nuno Sá via B4 Relay
2025-05-05 17:21 ` David Lechner
2025-05-07 6:11 ` Nuno Sá [this message]
2025-05-05 16:41 ` [PATCH v4 5/7] clk: clk-axi-clkgen: detect axi_clkgen_limits at runtime Nuno Sá via B4 Relay
2025-05-05 16:41 ` [PATCH v4 6/7] clk: clk-axi-clkgen move to min/max() Nuno Sá via B4 Relay
2025-05-05 16:41 ` [PATCH v4 7/7] clk: clk-axi-clkgen: fix coding style issues Nuno Sá via B4 Relay
2025-05-05 17:21 ` David Lechner
2025-05-07 6:08 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffebef8dd4255da67a8d6b7228f4e04e789532d5.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=broonie@kernel.org \
--cc=dlechner@baylibre.com \
--cc=dmaengine@vger.kernel.org \
--cc=hao.wu@intel.com \
--cc=jdelvare@suse.com \
--cc=jic23@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mdf@kernel.org \
--cc=mturquette@baylibre.com \
--cc=mturquette@linaro.org \
--cc=nuno.sa@analog.com \
--cc=sboyd@kernel.org \
--cc=tgamblin@baylibre.com \
--cc=trix@redhat.com \
--cc=ukleinek@kernel.org \
--cc=vkoul@kernel.org \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).