From: sashiko-bot@kernel.org
To: "Golla Nagendra" <nagendra.golla@amd.com>
Cc: vkoul@kernel.org, Frank.Li@kernel.org,
devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 4/6] dt-bindings: dma: xlnx,zynqmp-dma: Add Versal Net compatible support
Date: Fri, 09 Oct 2026 04:15:55 +0000 [thread overview]
Message-ID: <sashiko-outbox-164818@kernel.org> (raw)
In-Reply-To: <20261009-adma-pm-fix-and-per-channel-reset-v4-4-55f5fe409c55@amd.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: invalid fallback compatible due to mandatory reset requirement
--
commit 9c2ab7ce56ba7e0b6e011ec582d150236f1eafe6
Author: Jay Buddhabhatti <jay.buddhabhatti@amd.com>
dt-bindings: dma: xlnx,zynqmp-dma: Add Versal Net compatible support
This commit adds a new compatible string amd,versal-net-dma-1.0 and marks
the resets property as required for Versal Net. It also configures
xlnx,zynqmp-dma-1.0 as a fallback for the new compatible.
> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> index 2da86037ad79e..ff8c9a0e5559a 100644
> --- a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> +++ b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
[ ... ]
> @@ -16,17 +16,17 @@ maintainers:
> - Harini Katakam <harini.katakam@amd.com>
> - Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
>
> -allOf:
> - - $ref: ../dma-controller.yaml#
> -
> properties:
> "#dma-cells":
> const: 1
>
> compatible:
> - enum:
> - - amd,versal2-dma-1.0
> - - xlnx,zynqmp-dma-1.0
> + oneOf:
> + - const: amd,versal2-dma-1.0
> + - const: xlnx,zynqmp-dma-1.0
> + - items:
> + - const: amd,versal-net-dma-1.0
> + - const: xlnx,zynqmp-dma-1.0
[Severity: Medium]
Is it safe to provide a fallback compatible string here when the hardware
requires a mandatory reset?
If an older kernel encounters a device tree using this fallback, it will bind
to xlnx,zynqmp-dma-1.0. The older driver will then attempt to operate the
hardware without parsing or asserting the newly mandated resets property.
Since the commit message explicitly states the reset is essential to recover
from a bad firmware state, providing this fallback allows older drivers to
attempt to use the hardware in an unrecoverable state, contradicting the
purpose of the ABI break.
(Notice that amd,versal2-dma-1.0, which shares the same reset requirement,
correctly omits the fallback.)
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261009-adma-pm-fix-and-per-channel-reset-v4-0-55f5fe409c55@amd.com?part=4
next prev parent reply other threads:[~2026-10-09 4:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 4:00 [PATCH v4 0/6] dmaengine: zynqmp_dma: Per-channel reset, IRQ guard improvements, and PM fixes Golla Nagendra
2026-10-09 4:00 ` [PATCH v4 1/6] dmaengine: zynqmp_dma: Use PM guard for probe-time runtime PM reference Golla Nagendra
2026-10-10 3:09 ` Frank Li
2026-10-09 4:00 ` [PATCH v4 2/6] PM: runtime: Add pm_runtime_if_active guard and conditional variant Golla Nagendra
2026-10-09 4:10 ` sashiko-bot
2026-10-10 2:57 ` Frank Li
2026-10-09 4:00 ` [PATCH v4 3/6] dmaengine: zynqmp_dma: Guard IRQ handler against spurious interrupts Golla Nagendra
2026-10-10 2:59 ` Frank Li
2026-10-09 4:00 ` [PATCH v4 4/6] dt-bindings: dma: xlnx,zynqmp-dma: Add Versal Net compatible support Golla Nagendra
2026-10-09 4:15 ` sashiko-bot [this message]
2026-10-09 15:33 ` Conor Dooley
2026-10-09 4:00 ` [PATCH v4 5/6] dmaengine: zynqmp_dma: Add new compatible string for Versal Net Golla Nagendra
2026-10-09 4:00 ` [PATCH v4 6/6] dmaengine: zynqmp_dma: Add per-channel reset support Golla Nagendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-164818@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=nagendra.golla@amd.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox