Re: [PATCH 1/1] dma: ppc4xx: adma: remove unused async_tx.h include

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dma: ppc4xx: missing prototype for ppc440spe_async_tx_find_best_channel()
--

commit 9b901f64606c940ade9457f8242fc8c04d2f5fa6
Author: Frank Li <Frank.Li@nxp.com>

dma: ppc4xx: adma: remove unused async_tx.h include

The async_tx.h header is not directly used in adma.c; all required
types and functions come from dmaengine.h which is already included.
Remove the redundant include.

> Reduce async_tx.h user to prepare deprecate aysnc_tx framework.

This isn't a bug, but there is a typo (aysnc_tx) in the commit message.

> diff --git a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c
> index bcc54d584e2bf..05041b99581a1 100644
> --- a/drivers/dma/ppc4xx/adma.c
> +++ b/drivers/dma/ppc4xx/adma.c
> @@ -17,7 +17,6 @@
>  
>  #include <linux/init.h>
>  #include <linux/module.h>
> -#include <linux/async_tx.h>

[Severity: Low]
Does removing this include cause a missing prototype warning for
ppc440spe_async_tx_find_best_channel()?

This function is globally defined and exported via EXPORT_SYMBOL_GPL() later
in this file, but its only prototype declaration appears to be in
arch/powerpc/include/asm/async_tx.h, which was previously pulled in by this
include.

Without a matching prior prototype declaration, this could trigger a build
warning (-Wmissing-prototypes) when compiling drivers/dma/ppc4xx/adma.c.

>  #include <linux/delay.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/spinlock.h>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014201221.1806634-1-Frank.Li@oss.nxp.com?part=1