Re: [PATCH v4 2/2] dmaengine: replace dma_maxqp() with dmaengine_maxpq() taking struct dma_chan *

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dmaengine: stale documentation and comments after dma_maxpq rename
--

commit d1c8559bd7d041826990cfe2359c6880e20a68d4
Author: Frank Li <Frank.Li@nxp.com>

dmaengine: replace dma_maxqp() with dmaengine_maxpq() taking struct dma_chan *

This commit renames dma_maxpq() to dmaengine_maxpq() and updates it to take
a struct dma_chan pointer instead of a struct dma_device pointer. It also
updates the callers in the async_tx and dmatest subsystems to use the new
API convention.

Link: https://lore.kernel.org/dmaengine/20260923-dmaengine_prep_dma_pq-v2-0-32ed65b8a9b4@nxp.com/

> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index c6c212ba33734..3edd80eed0a2a 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
[ ... ]
> @@ -1443,7 +1443,7 @@ static inline unsigned short dma_dev_to_maxpq(struct dma_device *dma)
>  	return dma->max_pq & ~DMA_HAS_PQ_CONTINUE;
>  }
>  
> -/* dma_maxpq - reduce maxpq in the face of continued operations
> +/* dmaengine_maxpq - reduce maxpq in the face of continued operations
>   * @dma - dma device with PQ capability

[Severity: Low]
Should this kernel-doc comment be updated to document the new @chan
parameter instead of the removed @dma parameter?

Additionally, it looks like there is a stale reference to the old function
name in drivers/dma/ioat/prep.c that says "see the comment for dma_maxpq in
include/linux/dmaengine.h". Does that file need to be updated in this patch
to reflect the rename?

>   * @flags - to check if DMA_PREP_CONTINUE and DMA_PREP_PQ_DISABLE_P are set
>   *
> @@ -1456,8 +1456,10 @@ static inline unsigned short dma_dev_to_maxpq(struct dma_device *dma)
>   * In the case where P is disabled we only need 1 extra source:
>   * 1/ {01} * Q : use Q to continue Q' calculation
>   */
> -static inline int dma_maxpq(struct dma_device *dma, enum dma_ctrl_flags flags)
> +static inline int dmaengine_maxpq(struct dma_chan *chan, enum dma_ctrl_flags flags)
>  {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015155118.3063149-1-Frank.Li@oss.nxp.com?part=2