From: sashiko-bot@kernel.org
To: "Logan Gunthorpe" <logang@deltatee.com>, dmaengine@vger.kernel.org
Cc: vkoul@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v2 5/6] dmaengine: plx_dma: use spin_lock_bh() in plx_dma_process_desc()
Date: Tue, 10 Nov 2026 18:13:23 +0000 [thread overview]
Message-ID: <sashiko-outbox-207563@kernel.org> (raw)
In-Reply-To: <20261110173927.624629-6-logang@deltatee.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dmaengine: plx_dma: missing Fixes trailer for spin_lock_bh()
regression
--
commit 5f96c9ac9107b3e9b24578041180b3fa3a8f51ef
Author: Logan Gunthorpe <logang@deltatee.com>
> dmaengine: plx_dma: use spin_lock_bh() in plx_dma_process_desc()
>
> plx_dma_process_desc() is also called from plx_dma_tx_status() in
> process context. With a plain spin_lock(), the desc_task tasklet can
> run on the same CPU while the lock is held, and spin on it forever.
>
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Link: https://lore.kernel.org/dmaengine/20260717223217.B6FBF1F000E9@smtp.kernel.org
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
[Severity: Low]
This fixes the regression where spin_lock_bh() was replaced with spin_lock()
in plx_dma_process_desc(). Should this include:
Fixes: 1d05a0bdb420 ("dmaengine: plx_dma: Move spin_lock_bh() to spin_lock()")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261110173927.624629-1-logang@deltatee.com?part=5
next prev parent reply other threads:[~2026-11-10 18:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 17:39 [PATCH v2 0/6] plx_dma fixes Logan Gunthorpe
2026-11-10 17:39 ` [PATCH v2 1/6] dmaengine: plx_dma: don't call pci_irq_vector() under rcu_read_lock() Logan Gunthorpe
2026-11-10 17:39 ` [PATCH v2 2/6] dmaengine: plx_dma: fix descriptor ring leak in alloc_chan_resources() Logan Gunthorpe
2026-11-10 17:58 ` sashiko-bot
2026-11-10 18:15 ` Logan Gunthorpe
2026-11-10 20:52 ` Logan Gunthorpe
2026-11-10 17:39 ` [PATCH v2 3/6] dmaengine: plx_dma: use writel() for the 32-bit PLX_REG_CTRL register Logan Gunthorpe
2026-11-10 17:39 ` [PATCH v2 4/6] dmaengine: plx_dma: add dma_rmb() after observing write-back status Logan Gunthorpe
2026-11-10 18:08 ` sashiko-bot
2026-11-10 17:39 ` [PATCH v2 5/6] dmaengine: plx_dma: use spin_lock_bh() in plx_dma_process_desc() Logan Gunthorpe
2026-11-10 18:13 ` sashiko-bot [this message]
2026-11-10 17:39 ` [PATCH v2 6/6] dmaengine: plx_dma: don't invoke client callbacks with ring_lock held Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-207563@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox