Re: [PATCH 09/10] dmaengine: jz4780: Fix descriptor cleanup on hwdesc setup failure

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dmaengine: jz4780: Fixes trailer cites wrong introducing commit
--

commit 689fd02184422d0b30aad68612dbfd11c23b8306
Author: Lee Jones <lee@kernel.org>

> dmaengine: jz4780: Fix descriptor cleanup on hwdesc setup failure
> 
> When jz4780_dma_setup_hwdesc() fails in jz4780_dma_prep_slave_sg() or
> jz4780_dma_prep_dma_cyclic(), the error paths pass &jzchan->desc->vdesc
> to jz4780_dma_desc_free() instead of the newly allocated &desc->vdesc.
> This leaks the newly allocated descriptor and either dereferences NULL
> when jzchan->desc is NULL or frees the currently active descriptor while
> it is still in flight.  Furthermore, jz4780_dma_desc_free() derives
> jzchan from vdesc->tx.chan, which is not yet initialised before
> vchan_tx_prep() is called.
> 
> Initialise desc->vdesc.tx.chan in jz4780_dma_desc_alloc() and pass
> &desc->vdesc to jz4780_dma_desc_free() in the preparation error paths.
> 
> Fixes: d894fc6046fe ("dmaengine: jz4780: add driver for the Ingenic JZ4780 DMA controller")
> Closes: https://sashiko.dev/#/bug/linux-b39121ef-5ffb-401a-9d04-0afccd467bde
> Cc: stable@vger.kernel.org
> Signed-off-by: Lee Jones <lee@kernel.org>

[Severity: Low]
In d894fc6046fe ("dmaengine: jz4780: add driver for the Ingenic JZ4780 DMA
controller"), the preparation error paths did not call
jz4780_dma_desc_free() at all.  The broken
jz4780_dma_desc_free(&jzchan->desc->vdesc) calls before vchan_tx_prep()
were added later by fc878efe84c3 ("dmaengine: jz4780: fix resource leaks
on error exit return"), so the Fixes tag should be:

  Fixes: fc878efe84c3 ("dmaengine: jz4780: fix resource leaks on error exit return")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111215349.1983909-1-lee@kernel.org?part=9