Re: [PATCH v7 07/10] dmaengine: dw: report residue for queued transfers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dmaengine: dw: Fixes trailer cites 3bfb1d20b547 instead of
  b68fd0976286
--

commit cea2bb9706ea8fb5c7af2045e48883b9d2da9184
Author: James Hilliard <james.hilliard1@gmail.com>

> dmaengine: dw: report residue for queued transfers
>
> A submitted transfer may still be queued behind the active transaction.
> dwc_find_desc() only searches the active list, so a status query reports
> zero residue for the queued cookie even though none of its data has been
> transferred.
>
> Search the queue as well. The status getter already reports total_len for
> a descriptor that is not the active transaction, giving queued transfers
> their full remaining length.
>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Fixes: 3bfb1d20b547 ("dmaengine: Driver for the Synopsys DesignWare DMA controller")
> Cc: stable@vger.kernel.org
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

[Severity: Low]
Should the Fixes: tag point to b68fd0976286 ("dmaengine: dw: move residue
to a descriptor") instead?

Commit 3bfb1d20b547 ("dmaengine: Driver for the Synopsys DesignWare DMA
controller") did not have residue reporting or dwc_find_desc().  Commit
b68fd0976286 ("dmaengine: dw: move residue to a descriptor") added
dwc_find_desc() and the per-descriptor residue lookup, searching only
dwc->active_list after f336e42f73d9 ("dw_dmac: Move single descriptor
from dwc->queue to dwc->active_list in dwc_complete_all") had already
kept queued descriptors on dwc->queue.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115-submit-dw-dma-synchronize-v1-v7-0-8d58f3d49e4d@gmail.com?part=7