From: sashiko-bot@kernel.org
To: "Linus Walleij" <linusw@kernel.org>
Cc: dmaengine@vger.kernel.org, vkoul@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v2] dmaengine: ste_dma40: Use power domain for LCLA SRAM
Date: Sun, 22 Nov 2026 10:02:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-227882@kernel.org> (raw)
In-Reply-To: <20261122-ux500-dma40-powerdomain-v2-1-8a0ebfc75b80@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dmaengine: ste_dma40: chained dev_err_probe() in d40_probe()
clobbers reason
--
commit 8e29cc445c923c05eae5636fd084025260aae617
Author: Linus Walleij <linusw@kernel.org>
dmaengine: ste_dma40: Use power domain for LCLA SRAM
This commit replaces the LCLA ESRAM regulator and named memory resource
with an OF SRAM phandle and runtime PM management of the SRAM device.
> diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
> index f1cbc719c4f09..eca1ae95fe1c9 100644
> --- a/drivers/dma/ste_dma40.c
> +++ b/drivers/dma/ste_dma40.c
[ ... ]
> @@ -3781,13 +3791,70 @@ static int __init d40_of_probe(struct device *dev,
> return 0;
> }
>
> -static int __init d40_probe(struct platform_device *pdev)
> +static int d40_lcla_sram_setup(struct d40_base *base)
> +{
[ ... ]
> + if (!IS_ALIGNED(res.start, LCLA_ALIGNMENT) ||
> + resource_size(&res) < SZ_1K * base->num_phy_chans ||
> + res.end > U32_MAX) {
> + of_node_put(parent);
> + return dev_err_probe(dev, -EINVAL, "Invalid LCLA SRAM region\n");
> + }
[ ... ]
> @@ -3844,26 +3911,12 @@ static int __init d40_probe(struct platform_device *pdev)
> d40_err(dev, "Failed to ioremap LCPA region\n");
> goto report_failure;
> }
[ ... ]
> + ret = d40_lcla_sram_setup(base);
> + if (ret) {
> + dev_err_probe(dev, ret, "Failed to set up LCLA SRAM\n");
> + goto destroy_cache;
> + }
[ ... ]
> @@ -3954,22 +3987,18 @@ static int __init d40_probe(struct platform_device *pdev)
[ ... ]
> report_failure:
> - d40_err(dev, "probe failed\n");
> - return ret;
> + return dev_err_probe(dev, ret, "probe failed\n");
> }
[Severity: Low]
Does calling dev_err_probe() at report_failure overwrite the deferred
probe reason recorded by d40_lcla_sram_setup() or platform_get_irq() with
"probe failed"?
When d40_lcla_sram_setup() fails with a non-deferral error such as
-EINVAL, chaining dev_err_probe() across d40_lcla_sram_setup(), its caller
in d40_probe(), and report_failure also logs up to three error messages
for the same failure.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261122-ux500-dma40-powerdomain-v2-1-8a0ebfc75b80@kernel.org?part=1
prev parent reply other threads:[~2026-11-22 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 9:52 [PATCH v2] dmaengine: ste_dma40: Use power domain for LCLA SRAM Linus Walleij
2026-11-22 10:02 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-227882@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linusw@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).