From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh Subject: Re: [PATCH v2] test/test_mbuf: remove mempool global var Date: Thu, 22 Jun 2017 10:59:48 +0530 Message-ID: <0000d23c-0bfc-5e2d-752e-91cc5511c8c8@caviumnetworks.com> References: <20170608142831.28166-1-santosh.shukla@caviumnetworks.com> <2170817.cQF1WCe9mM@xps> <2118823.ueSLhbdIFl@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, olivier.matz@6wind.com, shreyansh.jain@nxp.com, stable@dpdk.org To: Thomas Monjalon Return-path: In-Reply-To: <2118823.ueSLhbdIFl@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tuesday 20 June 2017 01:05 PM, Thomas Monjalon wrote: > 20/06/2017 06:14, santosh: >> On Tuesday 20 June 2017 02:07 AM, Thomas Monjalon wrote: >> >>> 08/06/2017 16:28, Santosh Shukla: >>>> Let test_mbuf alloc and free mempool. >>>> >>>> Cc: stable@dpdk.org >>>> Signed-off-by: Santosh Shukla >>> Why Cc stable? >>> Is it fixing something? >>> >> w/o this fix, application can't run more than once. >> Reason: Static allocation of resources and exiting w/o freeing so leak. >> >> Patch makes app resource handling dynamic and Now user could run >> test more than once and app exits gracefully. thats why Cc: stable a need (IHMO). >> Thanks. > OK > So we need a Fixes: tag in order to be able to guess which > release it should be backported to. Hmmm, By git blame, Its a very early commit(af75078fe : first public release). And I think this patch can't be back-ported. IMO, I would prefer to remove Cc: stable@ from git description area, suggestion? is it fine. Yes, I will reword the git description.