From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chao Zhu" Subject: Re: [PATCH] eal/ppc64: revert implement arch-specific TSC freq query Date: Wed, 7 Feb 2018 15:02:26 +0800 Message-ID: <000701d39fe1$9d786f10$d8694d30$@linux.vnet.ibm.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Cc: To: "'Gowrishankar'" , Return-path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id D7F931B7E8 for ; Wed, 7 Feb 2018 08:02:33 +0100 (CET) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w176xKdL042611 for ; Wed, 7 Feb 2018 02:02:33 -0500 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 2fyqhgtqcb-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 07 Feb 2018 02:02:32 -0500 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 7 Feb 2018 07:02:30 -0000 In-Reply-To: Content-Language: zh-cn List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Gowrishankar [mailto:gowrishankar.m@linux.vnet.ibm.com] > Sent: 2018=C4=EA1=D4=C230=C8=D5 16:59 > To: dev@dpdk.org > Cc: Chao Zhu ; thomas@monjalon.net; > Gowrishankar Muthukrishnan > Subject: [PATCH] eal/ppc64: revert implement arch-specific TSC freq = query >=20 > From: Gowrishankar Muthukrishnan >=20 > This reverts commit 15692396fd68932b6a81f00f12d4b0da12baa7d3 > (eal/ppc64: implement arch-specific TSC freq query). We intended to = derive > pkt/sec estimation with cpu clock frequency. As timebase register = serves the > timer purpose, we need to stick with it for calculating pkt/sec, hence reverting > the change. >=20 > Fixes: 15692396fd (eal/ppc64: implement arch-specific TSC freq query) >=20 > Signed-off-by: Gowrishankar Muthukrishnan > > --- > lib/librte_eal/common/arch/ppc_64/rte_cycles.c | 47 +------------------------- > 1 file changed, 1 insertion(+), 46 deletions(-) >=20 > diff --git a/lib/librte_eal/common/arch/ppc_64/rte_cycles.c > b/lib/librte_eal/common/arch/ppc_64/rte_cycles.c > index 69a9f74..851fd02 100644 > --- a/lib/librte_eal/common/arch/ppc_64/rte_cycles.c > +++ b/lib/librte_eal/common/arch/ppc_64/rte_cycles.c > @@ -1,52 +1,7 @@ > -/* > - * BSD LICENSE > - * > - * Copyright (C) IBM Corporation 2014. > - * > - * Redistribution and use in source and binary forms, with or = without > - * modification, are permitted provided that the following = conditions > - * are met: > - * > - * * Redistributions of source code must retain the above = copyright > - * notice, this list of conditions and the following = disclaimer. > - * * Redistributions in binary form must reproduce the above copyright > - * notice, this list of conditions and the following disclaimer = in > - * the documentation and/or other materials provided with the > - * distribution. > - * * Neither the name of IBM Corporation nor the names of its > - * contributors may be used to endorse or promote products = derived > - * from this software without specific prior written = permission. > - * > - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND > CONTRIBUTORS > - * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT > NOT > - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND > FITNESS FOR > - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE > COPYRIGHT > - * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, > INCIDENTAL, > - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT > NOT > - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS > OF USE, > - * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED > AND ON ANY > - * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR > TORT > - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF > THE USE > - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH > DAMAGE. > - */ > - > -#include > -#include > -#include "eal_filesystem.h" > #include "eal_private.h" >=20 > -static const char sys_cpu_dir[] =3D "/sys/devices/system/cpu"; > - > uint64_t > get_tsc_freq_arch(void) > { > - unsigned long cpu_hz; > - char path[PATH_MAX]; > - > - snprintf(path, sizeof(path), "%s/cpu%d/cpufreq/cpuinfo_cur_freq", > - sys_cpu_dir, rte_get_master_lcore()); > - if (eal_parse_sysfs_value(path, &cpu_hz) < 0) > - RTE_LOG(WARNING, EAL, "Unable to parse %s\n", path); > - > - return cpu_hz*1000; > + return 0; > } > -- > 1.9.1 Acked-by: Chao Zhu