From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chao Zhu" <chaozhu@linux.vnet.ibm.com>
Subject: Re: [PATCH] eal/ppc64: revert implement arch-specific
	TSC freq query
Date: Wed, 7 Feb 2018 15:05:06 +0800
Message-ID: <000901d39fe1$fcdfcde0$f69f69a0$@linux.vnet.ibm.com>
References: <ff8e2632bd2ea1857d67d8b6f39410d69b701f21.1517302663.git.gowrishankar.m@linux.vnet.ibm.com>
 <3728847.cnur1V9eyL@xps>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Cc: <dev@dpdk.org>
To: "'Thomas Monjalon'" <thomas@monjalon.net>,
 "'Gowrishankar'" <gowrishankar.m@linux.vnet.ibm.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com
 [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 2C6051B7EA
 for <dev@dpdk.org>; Wed,  7 Feb 2018 08:05:15 +0100 (CET)
Received: from pps.filterd (m0098399.ppops.net [127.0.0.1])
 by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id
 w1774o7j025201 for <dev@dpdk.org>; Wed, 7 Feb 2018 02:05:14 -0500
Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108])
 by mx0a-001b2d01.pphosted.com with ESMTP id 2fyumsaebc-1
 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)
 for <dev@dpdk.org>; Wed, 07 Feb 2018 02:05:12 -0500
Received: from localhost
 by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
 Violators will be prosecuted
 for <dev@dpdk.org> from <chaozhu@linux.vnet.ibm.com>;
 Wed, 7 Feb 2018 07:05:10 -0000
In-Reply-To: <3728847.cnur1V9eyL@xps>
Content-Language: zh-cn
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

The previous patch has some misunderstanding of the the TSC frequency
counting.
I support this.

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: 2018=C4=EA2=D4=C21=C8=D5 8:30
> To: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>; Chao Zhu
> <chaozhu@linux.vnet.ibm.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] eal/ppc64: revert implement =
arch-specific
TSC
> freq query
>=20
> 30/01/2018 09:59, Gowrishankar:
> > From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
> >
> > This reverts commit 15692396fd68932b6a81f00f12d4b0da12baa7d3
> > (eal/ppc64: implement arch-specific TSC freq query). We intended to
> > derive pkt/sec estimation with cpu clock frequency. As timebase
> > register serves the timer purpose, we need to stick with it for
> > calculating pkt/sec, hence reverting the change.
> >
> > Fixes: 15692396fd (eal/ppc64: implement arch-specific TSC freq =
query)
>=20
> It is not clear what it is fixing.
>=20
> Chao, please review.