From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chao Zhu" <chaozhu@linux.vnet.ibm.com>
Subject: Re: [PATCH] eal/ppc64: revert implement arch-specific
	TSC freq query
Date: Wed, 7 Feb 2018 15:46:18 +0800
Message-ID: <000b01d39fe7$be271350$3a7539f0$@linux.vnet.ibm.com>
References: <ff8e2632bd2ea1857d67d8b6f39410d69b701f21.1517302663.git.gowrishankar.m@linux.vnet.ibm.com>
 <3728847.cnur1V9eyL@xps> <000901d39fe1$fcdfcde0$f69f69a0$@linux.vnet.ibm.com>
 <7852603.J7xFuoqAEp@xps>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: "'Gowrishankar'" <gowrishankar.m@linux.vnet.ibm.com>, <dev@dpdk.org>
To: "'Thomas Monjalon'" <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com
 [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id D153D1B6C2
 for <dev@dpdk.org>; Wed,  7 Feb 2018 08:46:25 +0100 (CET)
Received: from pps.filterd (m0098399.ppops.net [127.0.0.1])
 by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id
 w177iYGp001963 for <dev@dpdk.org>; Wed, 7 Feb 2018 02:46:23 -0500
Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109])
 by mx0a-001b2d01.pphosted.com with ESMTP id 2fyumsbyr1-1
 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)
 for <dev@dpdk.org>; Wed, 07 Feb 2018 02:46:23 -0500
Received: from localhost
 by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
 Violators will be prosecuted
 for <dev@dpdk.org> from <chaozhu@linux.vnet.ibm.com>;
 Wed, 7 Feb 2018 07:46:21 -0000
In-Reply-To: <7852603.J7xFuoqAEp@xps>
Content-Language: zh-cn
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Thomas,

I think it's OK to apply this patch now. It's been verified before and =
it's important for the correctness of the cycle counting on POWER.=20
Thank you!

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: 2018=E5=B9=B42=E6=9C=887=E6=97=A5 15:26
> To: Chao Zhu <chaozhu@linux.vnet.ibm.com>
> Cc: 'Gowrishankar' <gowrishankar.m@linux.vnet.ibm.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] eal/ppc64: revert implement =
arch-specific TSC
> freq query
>=20
> 07/02/2018 08:05, Chao Zhu:
> > The previous patch has some misunderstanding of the the TSC =
frequency
> > counting.
> > I support this.
>=20
> Chao, it is very late in the release cycle.
> Do you want to take the risk of applying this patch in 18.02-rc4?
> If you discover a bug in this patch next week, it will be too late for =
fixing it in
> 18.02.
>=20
>=20
> > > -----Original Message-----
> > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > Sent: 2018=E5=B9=B42=E6=9C=881=E6=97=A5 8:30
> > > To: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>; Chao Zhu
> > > <chaozhu@linux.vnet.ibm.com>
> > > Cc: dev@dpdk.org
> > > Subject: Re: [dpdk-dev] [PATCH] eal/ppc64: revert implement
> > > arch-specific
> > TSC
> > > freq query
> > >
> > > 30/01/2018 09:59, Gowrishankar:
> > > > From: Gowrishankar Muthukrishnan
> > > > <gowrishankar.m@linux.vnet.ibm.com>
> > > >
> > > > This reverts commit 15692396fd68932b6a81f00f12d4b0da12baa7d3
> > > > (eal/ppc64: implement arch-specific TSC freq query). We intended
> > > > to derive pkt/sec estimation with cpu clock frequency. As =
timebase
> > > > register serves the timer purpose, we need to stick with it for
> > > > calculating pkt/sec, hence reverting the change.
> > > >
> > > > Fixes: 15692396fd (eal/ppc64: implement arch-specific TSC freq
> > > > query)
> > >
> > > It is not clear what it is fixing.
> > >
> > > Chao, please review.
> >
> >
>=20
>=20