From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tony Lu <zlu@ezchip.com>
Subject: Re: [PATCH v1] Return ENOMEM during mpipe_devinit failure
Date: Thu, 20 Aug 2015 10:14:01 +0800
Message-ID: <000c01d0daed$ec601ad0$c5205070$@com>
References: <1440014407-3233-1-git-send-email-rkerur@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: 'Ravi Kerur' <rkerur@gmail.com>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from emea01-am1-obe.outbound.protection.outlook.com
 (mail-am1on0058.outbound.protection.outlook.com [157.56.112.58])
 by dpdk.org (Postfix) with ESMTP id 946435A88
 for <dev@dpdk.org>; Thu, 20 Aug 2015 04:14:23 +0200 (CEST)
In-Reply-To: <1440014407-3233-1-git-send-email-rkerur@gmail.com>
Content-Language: zh-cn
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

>-----Original Message-----
>From: Ravi Kerur [mailto:rkerur@gmail.com]
>Sent: Thursday, August 20, 2015 4:00 AM
>To: dev@dpdk.org
>Cc: zlu@ezchip.com; Ravi Kerur
>Subject: [PATCH v1] Return ENOMEM during mpipe_devinit failure
>
>In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate
>fails return error which is inline with other drivers.
>
>Signed-off-by: Ravi Kerur <rkerur@gmail.com>
>---
> drivers/net/mpipe/mpipe_tilegx.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/mpipe/mpipe_tilegx.c
>b/drivers/net/mpipe/mpipe_tilegx.c
>index 743feef..6e3e304 100644
>--- a/drivers/net/mpipe/mpipe_tilegx.c
>+++ b/drivers/net/mpipe/mpipe_tilegx.c
>@@ -1582,6 +1582,7 @@ rte_pmd_mpipe_devinit(const char *ifname,
> 	if (!eth_dev) {
> 		RTE_LOG(ERR, PMD, "%s: Failed to allocate device.\n",
ifname);
> 		rte_free(priv);
>+		return -ENOMEM;
> 	}
>
> 	RTE_LOG(INFO, PMD, "%s: Initialized mpipe device"
>--
>1.9.1

Thanks for fixing this.
Acked-by: Zhigang Lu <zlu@ezchip.com>