From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavel Fedin <p.fedin@samsung.com>
Subject: Re: [RFC 0/5] virtio support for container
Date: Thu, 31 Dec 2015 15:44:19 +0300
Message-ID: <003901d143c8$f8472f70$e8d58e50$@samsung.com>
References: <002a01d142e6$fbfeb4e0$f3fc1ea0$@samsung.com>
 <ED26CBA2FAD1BF48A8719AEF02201E36031B2708@shsmsx102.ccr.corp.intel.com>
 <002401d143af$38a6fa60$a9f4ef20$@samsung.com>
 <ED26CBA2FAD1BF48A8719AEF02201E36031B678C@shsmsx102.ccr.corp.intel.com>
 <002c01d143b7$568aace0$03a006a0$@samsung.com>
 <ED26CBA2FAD1BF48A8719AEF02201E36031B67ED@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
To: "'Tan, Jianfeng'" <jianfeng.tan@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com
 [210.118.77.13]) by dpdk.org (Postfix) with ESMTP id BE3E05A1F
 for <dev@dpdk.org>; Thu, 31 Dec 2015 13:44:22 +0100 (CET)
Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244])
 by mailout3.w1.samsung.com
 (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014))
 with ESMTP id <0O08000QQ3DXTY70@mailout3.w1.samsung.com> for dev@dpdk.org;
 Thu, 31 Dec 2015 12:44:21 +0000 (GMT)
In-reply-to: <ED26CBA2FAD1BF48A8719AEF02201E36031B67ED@shsmsx102.ccr.corp.intel.com>
Content-language: ru
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello!

> > a) ovs_in_container does not send VHOST_USER_SET_MEM_TABLE
> Please check if rte_eth_dev_start() is called.
> (rte_eth_dev_start -> virtio_dev_start -> vtpci_reinit_complete -> kick_all_vq)
> 
> > b) set_vring_addr() does not make sure that dev->mem is set.
> >  I am preparing a patch to fix (b).
> 
> Yes, it seems like a bug, lack of necessary check.

 I've made some progress about (a). It's tricky. This caused by this fragment:

        if (vhost_user_read(vhost->sockfd, &msg, len, fds, fd_num) < 0)
                return 0;

 Here you ignore errors. And this particular request for some reason ends up in EBADF. The most magic part is that sometimes it just
works...
 Not sure if i can finish it today, and here in Russia we have New Year holidays until 11th.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia