RE: [PATCH v9 00/16] Wangxun fixes and new features

["Zaiyu Wang" <zaiyuwang@trustnetic.com>]

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Friday, October 23, 2026 1:17 AM
> To: Zaiyu Wang <zaiyuwang@trustnetic.com>; Zaiyu Wang <zaiyuwang@trustnetic.com>
> Cc: dev@dpdk.org; dev@dpdk.org
> Subject: Re: [PATCH v9 00/16] Wangxun fixes and new features
> 
> On Thu, 22 Oct 2026 19:03:06 +0800
> Zaiyu Wang <zaiyuwang@trustnetic.com> wrote:
> 
> > This series addresses link-related issues on Wangxun Amber-lite 25G/40G NICs (CR/KR training, hot-plug, 10G link state).
> >
> > ---
> > v9:
> >  - P02: build autoneg_advertised from one mask instead of three ifs, and
> >         drop the out-of-tree reference from the message.
> >  - P03: fix the same wrong RXS field in txgbe_e56_cfg_10g(), and add the
> >         Fixes tag for the 25G commit that introduced that copy.
> >  - P10: report module removal and cancel the AN73 watchdog only on the
> >         transition to not-present, so an empty cage no longer repeats both
> >         on every poll.
> >  - P12: reset invalid bp_capa values to 0, log AML40 ffe_* values above
> > 	0xFF before their low bytes are replicated across the four lanes,
> >         and document the applicable FFE value range.
> >  - P13: clarify that laser_off disables the E56 PHY PMD through PMD_CFG0
> >         for DAC cables, while QSFP modules use the SFF-8636 Tx-disable byte.
> >  - P15: rewrite the unknown-module comment, drop the debug print that ran
> >         on every watchdog tick, and drop a commit-message bullet for a branch
> >         that is not in the parent tree.
> >  - P16: clear TXGBE_FLAG_NEED_LINK_CONFIG before the administrative-down
> >         early return, so a 25G SFP port can recover after set_link_down() and
> >         set_link_up().
> 
> Still seeing errors in AI review
> 
Hi Stephen,

I have gone through the AI review reports on this series.

Three of the four errors were withdrawn by the review itself. For the
last one I added a range check for the FFE taps in txgbe_ethdev.c. That
check is temporary: full range checking for the txgbe devargs depends on
the devargs changes that are still under discussion upstream, and I will
send it as a separate patch once those settle.

I also went through the warnings and info and fixed the ones that
applied. v10 is posted with those changes.

Thanks,
Zaiyu Wang