From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 20/23] net/atlantic: support for VLAN
 filters and offloads
Date: Thu, 11 Oct 2018 13:58:44 +0100
Message-ID: <008f670d-c81b-ec9c-f271-0ecfd12f2fa8@intel.com>
References: <cover.1539249721.git.igor.russkikh@aquantia.com>
 <275e2951a2e34edd797d8c30183c405e27e991e3.1539249721.git.igor.russkikh@aquantia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Pavel Belous <Pavel.Belous@aquantia.com>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 959B21B4F1
 for <dev@dpdk.org>; Thu, 11 Oct 2018 14:58:59 +0200 (CEST)
In-Reply-To: <275e2951a2e34edd797d8c30183c405e27e991e3.1539249721.git.igor.russkikh@aquantia.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/11/2018 11:35 AM, Igor Russkikh wrote:
> From: Pavel Belous <Pavel.Belous@aquantia.com>
> 
> VLAN filters and VLAN offloads implementation.
> 
> Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
> Signed-off-by: Pavel Belous <Pavel.Belous@aquantia.com>
> ---
>  doc/guides/nics/features/atlantic.ini |   2 +
>  drivers/net/atlantic/atl_ethdev.c     | 159 ++++++++++++++++++++++++++++++++++
>  drivers/net/atlantic/atl_types.h      |   2 +
>  3 files changed, 163 insertions(+)
> 
> diff --git a/doc/guides/nics/features/atlantic.ini b/doc/guides/nics/features/atlantic.ini
> index cfd6ca6a1323..f9aec42d9345 100644
> --- a/doc/guides/nics/features/atlantic.ini
> +++ b/doc/guides/nics/features/atlantic.ini
> @@ -16,8 +16,10 @@ Unicast MAC filter   = Y
>  RSS hash             = Y
>  RSS key update       = Y
>  RSS reta update      = Y
> +VLAN filter          = Y
>  Flow control         = Y
>  CRC offload          = Y
> +VLAN offload         = Y

If VLAN offload is enable, in Rx side mbuf->ol_flags should have PKT_RX_VLAN to
say mbuf->vlan_tci is valid.
And if vlan tag stripped from packet, mbuf->ol_flags should have
PKT_RX_VLAN_STRIPPED too.

I don't see these flags has been set in datapath, you can add it in this patch.