From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] ethdev: fix link status query
Date: Tue, 10 Apr 2018 19:34:48 +0100
Message-ID: <00a7e6bd-3549-4a76-ab74-276cf63141b6@intel.com>
References: <20180410061631.50301-1-shahafs@mellanox.com>
 <20180410082051.vhumihdzc3qhy7wy@laranjeiro-vm.dev.6wind.com>
 <4616956.1DYh5m3MiB@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>,
 dev@dpdk.org, stable@dpdk.org, stephen@networkplumber.org
To: Thomas Monjalon <thomas@monjalon.net>, Shahaf Shuler <shahafs@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <4616956.1DYh5m3MiB@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/10/2018 9:29 AM, Thomas Monjalon wrote:
> 10/04/2018 10:20, Nélio Laranjeiro:
>> On Tue, Apr 10, 2018 at 09:16:31AM +0300, Shahaf Shuler wrote:
>>> When application works with LSC interrupts the ethdev layer skips
>>> the PMD callback and update according to the link status exists on
>>> device data. It is because it assumes the link status on the device data
>>> is the correct one since any link change is processed by the application.
>>>
>>> As multiple PMDs install the link status interrupt handler only on port
>>> start and uninstall it on port stop, the link status may be incorrect in
>>> case the query is called after port stop or before port start.
>>
>> It seems also logical to not process interrupts from stopped device,
>> for them accessing to the link status should always end by calling the
>> devop function.
>>
>> This patch is the result of discussion on thread [1].
>>
>>> Fixing the query implementation to use the PMD callback for such cases.
>>>
>>> Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions")
>>> Cc: stable@dpdk.org
>>> Cc: stephen@networkplumber.org
>>> Cc: nelio.laranjeiro@6wind.com
>>
>> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>>
>>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> 
> Looks OK
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied to dpdk-next-net/master, thanks.