From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Hunt, David" <david.hunt@intel.com>
Subject: Re: [PATCH v2 4/4] power: clean up of power common header
Date: Mon, 11 Dec 2017 10:48:39 +0000
Message-ID: <00a8ba24-cff4-f88b-f5a7-bcb02d744c5e@intel.com>
References: <20171128132203.43181-1-marko.kovacevic@intel.com>
 <20171128132203.43181-4-marko.kovacevic@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Marko Kovacevic <marko.kovacevic@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id BAC1C271
 for <dev@dpdk.org>; Mon, 11 Dec 2017 11:48:42 +0100 (CET)
In-Reply-To: <20171128132203.43181-4-marko.kovacevic@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Marko,


On 28/11/2017 1:22 PM, Marko Kovacevic wrote:
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> ---
>   lib/librte_power/power_acpi_cpufreq.c                   | 2 +-
>   lib/librte_power/{rte_power_common.h => power_common.h} | 6 +++---
>   lib/librte_power/rte_power.c                            | 2 +-
>   3 files changed, 5 insertions(+), 5 deletions(-)
>   rename lib/librte_power/{rte_power_common.h => power_common.h} (95%)
>
> diff --git a/lib/librte_power/power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c
> index 165ec97..fd1931f 100644
> --- a/lib/librte_power/power_acpi_cpufreq.c
> +++ b/lib/librte_power/power_acpi_cpufreq.c
> @@ -45,7 +45,7 @@
>   #include <rte_atomic.h>
>   
>   #include "power_acpi_cpufreq.h"
> -#include "rte_power_common.h"
> +#include "power_common.h"
>   
>   #ifdef RTE_LIBRTE_POWER_DEBUG
>   #define POWER_DEBUG_TRACE(fmt, args...) do { \
> diff --git a/lib/librte_power/rte_power_common.h b/lib/librte_power/power_common.h
> similarity index 95%
> rename from lib/librte_power/rte_power_common.h
> rename to lib/librte_power/power_common.h
>

--snip--

Could I suggest adding the following into the commit message?

"Rename private header file rte_power_common.h to power_common.h to 
prevent private functions from leaking into the documentation."

Apart from that, if you make those changes, you can include my Ack in 
the next revision.

Series-Acked-By: David Hunt <david.hunt@intel.com>