From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] mk: parallelize make config
Date: Mon, 30 Jan 2017 09:41:15 +0000
Message-ID: <00b38d68-d431-8691-7c92-6d60350c8117@intel.com>
References: <20170122015034.19824-1-ferruh.yigit@intel.com>
 <CAHXqBF+c+1mBXxu-dtR93E5yEXkPsHNTozrsBNsAd1akcVaySQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, Thomas Monjalon <thomas.monjalon@6wind.com>
To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirqus@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 47E2A98
 for <dev@dpdk.org>; Mon, 30 Jan 2017 10:41:18 +0100 (CET)
In-Reply-To: <CAHXqBF+c+1mBXxu-dtR93E5yEXkPsHNTozrsBNsAd1akcVaySQ@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/23/2017 7:03 PM, Michał Mirosław wrote:
> 2017-01-22 2:50 GMT+01:00 Ferruh Yigit <ferruh.yigit@intel.com>:
>> make config dependency resolving was always running serial,
>> parallelize it for better performance.
>>
>> $ time make T=x86_64-native-linuxapp-gcc config
>> real    0m12.633s
>>
>> $ time make -j8 T=x86_64-native-linuxapp-gcc config
>> real    0m1.826s
> [...]
>> +$(RTE_OUTPUT)/.depdirs: $(DEPDIRS)
>> +       @rm -f $@
>> +       @for f in $(DEPDIRS); do cat $$f >> $@; done
>> +       @sort -u -o $@ $@
> 
> This could be just one 'sort -u -o $@ $(DEPDIRS)'

Yes, I will update in next version, thanks.

> 
> Best Regards,
> Michał Mirosław
>