From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Laatz, Kevin" <kevin.laatz@intel.com>
Subject: Re: [PATCH] usertools: replace unsafe input function
Date: Wed, 3 Apr 2019 11:31:09 +0100
Message-ID: <00d20004-b191-51b3-55e3-776ff734b45e@intel.com>
References: <1553100181-32934-1-git-send-email-andrius.sirvys@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: stable@dpdk.org, ciara.power@intel.com
To: Andrius Sirvys <andrius.sirvys@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1553100181-32934-1-git-send-email-andrius.sirvys@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 20/03/2019 16:43, Andrius Sirvys wrote:
> LGTM static code analysis tool reports that the function 'input' is
> unsafe. Changed to use raw_input which then converts it using
> ast.literal_eval() which is safe.
>
> Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry")
> Cc: ciara.power@intel.com
>
> Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
> ---

Looks good to me. Thanks!

Acked-by: Kevin Laatz <kevin.laatz@intel.com>