From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INVALID_MSGID, MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC26CC433DB for ; Fri, 26 Mar 2021 02:02:39 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id C9F2961A06 for ; Fri, 26 Mar 2021 02:02:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9F2961A06 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=trustnetic.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D5D6140DE3; Fri, 26 Mar 2021 03:02:38 +0100 (CET) Received: from smtpproxy21.qq.com (smtpbg702.qq.com [203.205.195.102]) by mails.dpdk.org (Postfix) with ESMTP id A6CE14067B for ; Fri, 26 Mar 2021 03:02:36 +0100 (CET) X-QQ-mid: bizesmtp6t1616724151ty95x4fby Received: from jiawenwu (unknown [183.129.236.74]) by esmtp6.qq.com (ESMTP) with id ; Fri, 26 Mar 2021 10:02:31 +0800 (CST) X-QQ-SSF: 01400000002000D0E000B00A0000000 X-QQ-FEAT: fwmM14zYGCicn3rSxVSPjl59eZ0XlNT1lXo4BDd6qtV+RutYjK2RFIOirwEek Ry47/KfpRAQuIoRR/tJninnkOU95zufhcXDUx1q02QLchCWSlaxxGzCYbFEOhZrE4F1sKiK BhuXH20/VjBr7ensXj4U7BRgwEOEgvZtPNG8/oLOn6C76Rk5adSRIFZ6Z6qj9PN/VuG5SVu S0Hm4mtb4c+DCelKpeJMb2wiyHpQTlkigwnNTpvm5ENzaoRGGrdrnYvm3sRoyXrlSGe081e G/92TIVsgHQ+2zE/bzA6hCHzrYHLsrxLKHtLjUVbQsRTGY36HZM7AsQE7UEhBjoECeg86dP qBHXdVP X-QQ-GoodBg: 2 From: "Jiawen Wu" To: "'Ferruh Yigit'" , References: <20210325055141.629963-1-jiawenwu@trustnetic.com> <20210325055141.629963-4-jiawenwu@trustnetic.com> <603dc490-6524-aac4-4865-5670d9ecb9ca@intel.com> In-Reply-To: <603dc490-6524-aac4-4865-5670d9ecb9ca@intel.com> Date: Fri, 26 Mar 2021 10:02:30 +0800 Message-ID: <00f701d721e4$14d4f600$3e7ee200$@trustnetic.com>+B8BEF8298907603B MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGQ4Kh8LyId+XhZlLGAV5ICqrp6ygJOx1dQAoMoUuKq+3HiMA== Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign5 X-QQ-Bgrelay: 1 Subject: Re: [dpdk-dev] [PATCH v3 3/7] net/txgbe: update link setup process of backplane NICs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On March 25, 2021 6:20 PM, Ferruh Yigit wrote: > On 3/25/2021 5:51 AM, Jiawen Wu wrote: > > Add device arguments to support runtime options. > > And use these configuration to control the link setup flow, to adapt > > to different NIC's construction. Use firmware version to control the > > impact of firmware update. And fix some left bugs. > > > > Signed-off-by: Jiawen Wu >=20 > <...> >=20 > > +#define TXGBE_DEBUG_BP > > +#ifdef TXGBE_DEBUG_BP > > +#define BP_LOG(fmt, ...) \ > > + RTE_LOG(CRIT, PMD, "[%lu.%lu]%s(%d): " fmt, \ > > + usec_stamp() / 1000000, usec_stamp() % 1000000, \ > > + __func__, __LINE__, ## __VA_ARGS__) #else #define > BP_LOG(fmt, ...) > > +do { } while (0) #endif > > + > > #endif /* _TXGBE_LOGS_H_ */ > > >=20 > The 'BP_LOG' looks like used for developer debug prints, if so I = suggest > removing them completely, but if not can you please convert it dynamic = logging, > or using existing dynamic logs 'txgbe_logtype_init', = 'txgbe_logtype_driver'? >=20 > Thanks, > ferruh I think it should not be removed, since the user needs to adjust 'ffe' = parameters according to the logs. I considered converting it to dynamic logging. = But when the log level is 'debug', it will result in the printing of other logs, which I = don't need. Should I lower the log level of 'BP_LOG', to avoid the above situation?