From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Ferruh Yigit'" <ferruh.yigit@amd.com>, <dev@dpdk.org>
Subject: RE: [PATCH] net/txgbe: fix a mass of interrupts
Date: Tue, 19 Nov 2024 10:02:23 +0800 [thread overview]
Message-ID: <010301db3a27$130f31a0$392d94e0$@trustnetic.com> (raw)
In-Reply-To: <ff803425-d546-4502-b695-75cd60c59181@amd.com>
On Tue, Nov 19, 2024 3:59 AM, Ferruh Yigit wrote:
> On 11/15/2024 8:33 AM, Jiawen Wu wrote:
> > Since firmware version 0x20010, GPIO interrupt enable is set to 0xd by
> > default, which means enable bit 0 'tx_fault'. And GPIO interrupt polarity
> > is set to 0xd by default too, which means these interrupts are rising-edge
> > sensitive.
> >
> > So when unplug the SFP module, GPIO line 0 'tx_fault' is 0 -> 1 triggers
> > the interrupt. However, the interrupt is not cleared. And GPIO interrupt
> > mask is enabled and disabled to trigger the MISC interrupt repeatedly.
> >
> > Since this 'tx_fault' interrupt does not make much sense, simply clear it
> > to fix the issue.
> >
> > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> >
>
> Hi Jiawen,
>
> Can you please provide a fixes tag?
> Also I believe you would like to backport this fix, if so please add the
> stable tag as well.
I have thought about it. But there are two changes based on two commits:
1. d3bb4a04eac1 ("net/txgbe: add SFP hotplug identification")
2. 12011b11a3d6 ("net/txgbe: adapt to MNG veto bit setting")
Should I split the patch and add fixes tags separately?
next prev parent reply other threads:[~2024-11-19 2:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 8:33 [PATCH] net/txgbe: fix a mass of interrupts Jiawen Wu
2024-11-18 19:59 ` Ferruh Yigit
2024-11-19 2:02 ` Jiawen Wu [this message]
2024-11-24 17:46 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='010301db3a27$130f31a0$392d94e0$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).