From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [PATCH v3] examples/ipsec-secgw: limit inflight
 packets count
Date: Wed, 9 May 2018 17:32:29 +0530
Message-ID: <01c2959d-1214-3309-b943-d08d4c20d5e5@nxp.com>
References: <1525856209-27513-1-git-send-email-radu.nicolau@intel.com>
 <1525856321-27612-1-git-send-email-radu.nicolau@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: akhil.goyal@nxp.com, pablo.de.lara.guarch@intel.com, stable@dpdk.org
To: Radu Nicolau <radu.nicolau@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1525856321-27612-1-git-send-email-radu.nicolau@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/9/2018 2:28 PM, Radu Nicolau wrote:
> Revert previous patch that introduce a performance
> degradation in certain scenarios and add a configurable
> limit for number inflight packets.
>
> Revert
> commit 84d4b5e4ec48 ("examples/ipsec-secgw: improve IPsec dequeue logic")
> Cc: stable@dpdk.org
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
> v3: updated enqueue size trim computation
>
>  examples/ipsec-secgw/ipsec.c | 32 +++++++++++++++-----------------
>  examples/ipsec-secgw/ipsec.h |  1 +
>  2 files changed, 16 insertions(+), 17 deletions(-)
>
> diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
> index ee24973..1929752 100644
> --- a/examples/ipsec-secgw/ipsec.c
> +++ b/examples/ipsec-secgw/ipsec.c
> @@ -348,13 +348,19 @@ create_session(struct ipsec_ctx *ipsec_ctx, struct ipsec_sa *sa)
>  static inline void
>  enqueue_cop(struct cdev_qp *cqp, struct rte_crypto_op *cop)
>  {
> -	int32_t ret, i;
> +	int32_t ret = 0, i;
>
>  	cqp->buf[cqp->len++] = cop;
>
>  	if (cqp->len == MAX_PKT_BURST) {
> -		ret = rte_cryptodev_enqueue_burst(cqp->id, cqp->qp,
> -				cqp->buf, cqp->len);
> +		int enq_size = cqp->len;
> +		if ((cqp->in_flight + enq_size) >= MAX_INFLIGHT)

This should be ((cqp->in_flight + enq_size) > MAX_INFLIGHT). there Will 
be one extra operation in case it is equal.

Otherwise,
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>