From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh Subject: Re: [PATCH v4 02/15] mem: introduce IOVA type Date: Mon, 6 Nov 2017 14:21:20 +0530 Message-ID: <020f79b0-8d81-7e5f-fd28-089f38e27723@caviumnetworks.com> References: <20170814151537.29454-1-santosh.shukla@caviumnetworks.com> <20171106014141.13266-3-thomas@monjalon.net> <80cb9e8f-c493-4b5f-909f-9ae233ba6541@caviumnetworks.com> <3304743.b7VfCBXbgQ@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: olivier.matz@6wind.com, sergio.gonzalez.monroy@intel.com, anatoly.burakov@intel.com, dev@dpdk.org To: Thomas Monjalon Return-path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0048.outbound.protection.outlook.com [104.47.34.48]) by dpdk.org (Postfix) with ESMTP id E0B9F1B27C for ; Mon, 6 Nov 2017 09:51:35 +0100 (CET) In-Reply-To: <3304743.b7VfCBXbgQ@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Monday 06 November 2017 02:07 PM, Thomas Monjalon wrote: > 06/11/2017 06:38, santosh: >> On Monday 06 November 2017 07:11 AM, Thomas Monjalon wrote: >>> The IO virtual addresses may be used instead of physical addresses. >>> As IOVA is more generic, it should be used in most places instead >>> of physical address wording. >>> >>> Signed-off-by: Thomas Monjalon >>> --- >>> +/** >>> + * IO virtual address type. >>> + * When the physical addressing mode is in use, >>> + * the translation from a virtual address to a physical address >>> + * is a direct mapping, i.e. the same value. >>> + */ >> I guess - that description applicable for iova=va mode >> and for iova=pa mode - Need to do explicit virt2phy translation. >> I believe you mis-wrote - s/physical addressing mode/virtual addressing mode. > Not sure to understand your comment. > Let me reword the description to be less ambiguous: > > * When the physical addressing mode (IOVA as PA) is in use, > * the translation from an IO virtual address (IOVA) to a physical address > * is a direct mapping, i.e. the same value. > * Otherwise, in virtual mode (IOVA as VA), an IOMMU may do the translation. > > Is this description correct? > Yes.