From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Thomas Monjalon'" <thomas@monjalon.net>, <dev@dpdk.org>
Cc: "'Xingui Yang'" <yangxingui@huawei.com>,
"'Chengwen Feng'" <fengchengwen@huawei.com>,
"'Zaiyu Wang'" <zaiyuwang@trustnetic.com>,
"'Christian Koue Muf'" <ckm@napatech.com>,
"'Serhii Iliushyk'" <sil-plv@napatech.com>,
"'Cristian Dumitrescu'" <cristian.dumitrescu@intel.com>,
"'Jian Wang'" <jianwang@trustnetic.com>,
"'Andrew Rybchenko'" <andrew.rybchenko@oktetlabs.ru>,
"'Morten Brørup'" <mb@smartsharesystems.com>,
"'Sunil Kumar Kori'" <skori@marvell.com>,
"'Xingui Yang'" <yangxingui@huawei.com>,
"'Chengwen Feng'" <fengchengwen@huawei.com>,
"'Zaiyu Wang'" <zaiyuwang@trustnetic.com>,
"'Christian Koue Muf'" <ckm@napatech.com>,
"'Serhii Iliushyk'" <sil-plv@napatech.com>,
"'Cristian Dumitrescu'" <cristian.dumitrescu@intel.com>,
"'Jian Wang'" <jianwang@trustnetic.com>,
"'Andrew Rybchenko'" <andrew.rybchenko@oktetlabs.ru>,
"'Morten Brørup'" <mb@smartsharesystems.com>,
"'Sunil Kumar Kori'" <skori@marvell.com>
Subject: RE: [PATCH] drivers/net: fix Tx packet prepare
Date: Thu, 20 Nov 2025 09:57:48 +0800 [thread overview]
Message-ID: <023801dc59c1$122cfa50$3686eef0$@trustnetic.com> (raw)
In-Reply-To: <20251119130333.2697937-1-thomas@monjalon.net>
On Wed, Nov 19, 2025 9:04 PM, Thomas Monjalon wrote:
> After removing callback checks from ethdev fast path,
> some drivers crashed because tx_pkt_prepare was set to NULL.
>
> Some drivers (hns3, ngbe, txgbe) need to use rte_eth_tx_pkt_prepare_dummy
> when configuring queues.
> Other drivers (ntnic, softnic) does not need to set tx_pkt_prepare
> as it was set by eth_dev_set_dummy_fops() called by rte_eth_dev_allocate().
>
> Bugzilla ID: 1834
> Fixes: 066f3d9cc21c ("ethdev: remove callback checks from fast path")
>
> Reported-by: Jiawen Wu <jiawenwu@trustnetic.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Tested-by: Jiawen Wu <jiawenwu@trustnetic.com>
next prev parent reply other threads:[~2025-11-20 1:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 13:03 [PATCH] drivers/net: fix Tx packet prepare Thomas Monjalon
2025-11-19 13:19 ` Morten Brørup
2025-11-19 13:44 ` Thomas Monjalon
2025-11-19 13:50 ` Morten Brørup
2025-11-20 1:57 ` Jiawen Wu [this message]
2025-11-20 5:50 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='023801dc59c1$122cfa50$3686eef0$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=ckm@napatech.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=jianwang@trustnetic.com \
--cc=mb@smartsharesystems.com \
--cc=sil-plv@napatech.com \
--cc=skori@marvell.com \
--cc=thomas@monjalon.net \
--cc=yangxingui@huawei.com \
--cc=zaiyuwang@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).