From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 3/6] net/enic: flow API for NICs with
 advanced filters disabled
Date: Wed, 17 May 2017 12:13:09 +0100
Message-ID: <026046f6-5145-e7c8-a00e-b703e81a1d40@intel.com>
References: <20170331020622.25498-8-johndale@cisco.com>
 <20170517030348.2663-1-johndale@cisco.com>
 <20170517030348.2663-4-johndale@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: John Daley <johndale@cisco.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 2186A2986
 for <dev@dpdk.org>; Wed, 17 May 2017 13:13:12 +0200 (CEST)
In-Reply-To: <20170517030348.2663-4-johndale@cisco.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/17/2017 4:03 AM, John Daley wrote:
> Flow support for 1300 series adapters with the 'Advanced Filter'
> mode disabled via the UCS management interface. This allows:
> Attributes: ingress
> Items: Outer eth, ipv4, ipv6, udp, sctp, tcp, vxlan. Inner eth, ipv4,
>        ipv6, udp, tcp.
> Actions: queue and void
> Selectors: 'is', 'spec' and 'mask'. 'last' is not supported
> 
> With advanced filters disabled, an IPv4 or IPv6 item must be specified
> in the pattern.
> 
> Signed-off-by: John Daley <johndale@cisco.com>
> Reviewed-by: Nelson Escobar <neescoba@cisco.com>

<...>

> @@ -193,6 +279,10 @@ static const enum rte_flow_action_type enic_supported_actions_v2[] = {
>  
>  /** Action capabilites indexed by NIC version information */
>  static const struct enic_action_cap enic_action_cap[] = {
> +	[FILTER_ACTION_RQ_STEERING_FLAG] = {

FILTER_ACTION_RQ_STEERING_FLAG doesn't defined anywhere which is causing
build error, compiler asks if you mean FILTER_ACTION_RQ_STEERING:

drivers/net/enic/enic_flow.c:318:3: error: use of undeclared identifier
'FILTER_ACTION_RQ_STEERING_FLAG'; did you mean 'FILTER_ACTION_RQ_STEERING'?