From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 34/34] net/ice: support meson build
Date: Thu, 13 Dec 2018 21:15:42 +0000
Message-ID: <0260ab4a-6c7e-492d-519f-20975750986c@intel.com>
References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com>
 <1544598004-27099-1-git-send-email-wenzhuo.lu@intel.com>
 <1544598004-27099-35-git-send-email-wenzhuo.lu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id DCAE01B599
 for <dev@dpdk.org>; Thu, 13 Dec 2018 22:15:44 +0100 (CET)
In-Reply-To: <1544598004-27099-35-git-send-email-wenzhuo.lu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/12/2018 7:00 AM, Wenzhuo Lu wrote:
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> ---
>  drivers/net/ice/base/meson.build | 30 ++++++++++++++++++++++++++++++
>  drivers/net/ice/meson.build      | 15 +++++++++++++++
>  drivers/net/meson.build          |  1 +

I think it is better to add meson file with on the patch Makefile added and
update in patches where required, instead of having a separate patch for it

>  3 files changed, 46 insertions(+)
>  create mode 100644 drivers/net/ice/base/meson.build
>  create mode 100644 drivers/net/ice/meson.build
> 
> diff --git a/drivers/net/ice/base/meson.build b/drivers/net/ice/base/meson.build
> new file mode 100644
> index 0000000..5aafff3
> --- /dev/null
> +++ b/drivers/net/ice/base/meson.build
> @@ -0,0 +1,30 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2018 Intel Corporation
> +
> +sources = [
> +	'ice_controlq.c',
> +	'ice_common.c',
> +	'ice_sched.c',
> +	'ice_switch.c',
> +	'ice_nvm.c',

ice_dcb.c? It is in base folder, isn't is compiled?

<...>

> @@ -0,0 +1,15 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2018 Intel Corporation
> +
> +cflags += ['-DALLOW_EXPERIMENTAL_API']

Makefile doesn't have this flag, I guess it is not needed, base folder meson
file also has it.