From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 5/5] net/netvsc: integrated VF support
Date: Fri, 14 Sep 2018 13:57:58 +0100
Message-ID: <03884d78-ac63-4d47-2392-bd1e3cab4d58@intel.com>
References: <20180830223512.21297-1-stephen@networkplumber.org>
 <20180830223512.21297-6-stephen@networkplumber.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Stephen Hemminger <sthemmin@microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id 830D15B3E
 for <dev@dpdk.org>; Fri, 14 Sep 2018 14:58:11 +0200 (CEST)
In-Reply-To: <20180830223512.21297-6-stephen@networkplumber.org>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 8/30/2018 11:35 PM, Stephen Hemminger wrote:
> From: Stephen Hemminger <sthemmin@microsoft.com>
> 
> Integrate accelerated networking support into netvsc PMD.
> This allows netvsc to manage VF without using failsafe or vdev_netvsc.
> For the exception vswitch path some tests like transmit
> get a 22% increase in packets/sec.
> For the VF path, the code is slightly shorter but has no
> real change in performance.
> 
> Pro:
>    * using netvsc is more like other DPDK NIC's
>    * the exception packet uses less CPU
>    * much smaller code size
>    * no locking required on VF transmit/receive path
>    * no legacy Linux network device to get mangled by userspace
>    * much simpler (1K vs 9K) LOC
>    * unified extended statistics
> 
> Con:
>    * using netvsc has more complex startup model
>    * no bifurcated driver support
>    * no flow support (since host does not have flow API).
>    * no tunnel offload support
>    * no receive interrupt support
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> ---
>  devtools/checkpatches.sh               |   2 +-
>  doc/guides/nics/netvsc.rst             |  12 +-
>  doc/guides/rel_notes/release_18_11.rst |  14 +-
>  drivers/net/netvsc/Makefile            |   1 +
>  drivers/net/netvsc/hn_ethdev.c         | 109 +++++-
>  drivers/net/netvsc/hn_nvs.c            |  11 +-
>  drivers/net/netvsc/hn_nvs.h            |   9 +
>  drivers/net/netvsc/hn_rndis.c          |  31 ++
>  drivers/net/netvsc/hn_rndis.h          |   1 +
>  drivers/net/netvsc/hn_rxtx.c           | 136 ++++---
>  drivers/net/netvsc/hn_var.h            |  43 ++-
>  drivers/net/netvsc/hn_vf.c             | 512 +++++++++++++++++++++++++
>  drivers/net/netvsc/meson.build         |   2 +-
>  13 files changed, 799 insertions(+), 84 deletions(-)
>  create mode 100644 drivers/net/netvsc/hn_vf.c
> 
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index ba795ad1dc36..db7afc43d4c0 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -1,4 +1,4 @@
> -#! /bin/sh
> +#! /bin/bash
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright 2015 6WIND S.A.

This tool patch shouldn't be part of driver update, would you mind sending a
separate patch for it?