From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 1/2] ethdev: add supported hash function
 check
Date: Tue, 1 May 2018 12:04:55 +0100
Message-ID: <03cfea68-a04f-e36d-add8-beca273be5ba@intel.com>
References: <20180409121035.148813-1-xuemingl@mellanox.com>
 <20180420143023.117071-1-xuemingl@mellanox.com>
 <6f9cfb31-850d-b52a-c1d6-abd9d1406b41@intel.com> <6300361.pQ73498XhG@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Shahaf Shuler <shahafs@mellanox.com>,
 Nelio Laranjeiro <notifications@github.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>, dev@dpdk.org,
 John McNamara <john.mcnamara@intel.com>, Qi Zhang <qi.z.zhang@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, Xueming Li <xuemingl@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 6E7DB1E35
 for <dev@dpdk.org>; Tue,  1 May 2018 13:05:00 +0200 (CEST)
In-Reply-To: <6300361.pQ73498XhG@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/23/2018 7:14 PM, Thomas Monjalon wrote:
> 23/04/2018 18:06, Ferruh Yigit:
>> On 4/20/2018 3:30 PM, Xueming Li wrote:
>>> Add supported RSS hash function check in device configuration to
>>> have better error verbosity for application developers.
>>>
>>> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
>>> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>>>  
>>> +	/* Check that device supports requested rss hash functions. */
>>> +	if ((dev_info.flow_type_rss_offloads |
>>> +	     dev_conf->rx_adv_conf.rss_conf.rss_hf) !=
>>> +	    dev_info.flow_type_rss_offloads) {
>>> +		RTE_PMD_DEBUG_TRACE("ethdev port_id=%d invalid rss_hf: "
>>> +				    "0x%"PRIx64", valid value: 0x%"PRIx64"\n",
>>> +				    port_id,
>>> +				    dev_conf->rx_adv_conf.rss_conf.rss_hf,
>>> +				    dev_info.flow_type_rss_offloads);
>>> +		return -EINVAL;
>>> +	}
>>
>> Hi Thomas,
>>
>> This can break the PMDs that are not setting flow_type_rss_offloads properly.
>> How can we highlight this so that PMD owners can double check?
> 
> Can we have a check-list in the RC1 announce email?

Hi Thomas, Xueming,

This change is breaking multiple sample applications, testpmd was also broken
but already fixed by Qi [1].

Indeed this patch should update sample applications and testpmd as well when
doing an ethdev API update, also should update release notes "API Changes" section.

We can fix sample applications for rc2, but same thing also can hit users.

Or for this release we can remote returning error, instead update log message to
error. Next release add the return and change log message back to debug.

What do you think?


[1]
Commit: 9089296206ce ("app/testpmd: fix config due to RSS offload check")