From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH v4 4/4] app/testpmd: display/clear forwarding
 stats on demand
Date: Fri, 22 Mar 2019 18:22:05 +0100
Message-ID: <0442d79f-0e74-3633-02c9-f6f4234881fb@redhat.com>
References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com>
 <1553261824-1881-1-git-send-email-david.marchand@redhat.com>
 <1553261824-1881-5-git-send-email-david.marchand@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com,
 ramirose@gmail.com, arybchenko@solarflare.com, ferruh.yigit@intel.com
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id A68311B6F7
 for <dev@dpdk.org>; Fri, 22 Mar 2019 18:22:12 +0100 (CET)
In-Reply-To: <1553261824-1881-5-git-send-email-david.marchand@redhat.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 3/22/19 2:37 PM, David Marchand wrote:
> Add a new "show/clear fwd stats all" command to display fwd and port
> statistics on the fly.
> 
> To be able to do so, the (testpmd only) rte_port structure can't be used
> to maintain any statistics.
> Moved the stats dump parts from stop_packet_forwarding() and merge with
> fwd_port_stats_display() into fwd_stats_display().
> fwd engine statistics are then aggregated into a local per port array.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changelog since v3:
> - added description in testpmd usage
> - renamed cmd_fwdall as cmd_showfwdall
> 
> Changelog since v1:
> - removed hunk from now deleted patch 3
> 
> ---
>   app/test-pmd/cmdline.c                      |  49 ++++
>   app/test-pmd/testpmd.c                      | 425 +++++++++++++++-------------
>   app/test-pmd/testpmd.h                      |   9 +-
>   doc/guides/testpmd_app_ug/testpmd_funcs.rst |  36 +++
>   4 files changed, 310 insertions(+), 209 deletions(-)
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>