From mboxrd@z Thu Jan  1 00:00:00 1970
From: Igor Ryzhov <iryzhov@nfware.com>
Subject: Re: rte_ether: Driver-specific stats getting overwritten
Date: Thu, 14 Jul 2016 16:51:49 +0300
Message-ID: <04EE3350-421C-47F9-9D6F-A1D4992FD932@nfware.com>
References: <1195a38d-8615-03d2-22eb-04f6b071d38b@intel.com>
 <1954062.51W9tGj6hj@xps13>
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Remy Horton <remy.horton@intel.com>,
 dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com
 [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id 0F2E437A4
 for <dev@dpdk.org>; Thu, 14 Jul 2016 15:51:51 +0200 (CEST)
Received: by mail-lf0-f68.google.com with SMTP id 33so5430998lfw.3
 for <dev@dpdk.org>; Thu, 14 Jul 2016 06:51:51 -0700 (PDT)
In-Reply-To: <1954062.51W9tGj6hj@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello.

How about deleting rx_nombuf from rte_eth_stats?
Do you think this counter is necessary? It just shows enormous numbers =
in case of a lack of processing speed.
But we already have imissed counter which shows real number of packets, =
dropped for the same reason.

> 14 =D0=B8=D1=8E=D0=BB=D1=8F 2016 =D0=B3., =D0=B2 16:37, Thomas =
Monjalon <thomas.monjalon@6wind.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=
=BB(=D0=B0):
>=20
> 2016-07-14 14:29, Remy Horton:
>> 'noon,
>>=20
>> In rte_eth_stats_get() after doing the driver callout to populate =
struct=20
>> rte_eth_stats, the rx_nombuf member is overwritten with=20
>> dev->data->rx_mbuf_alloc_failed even though some drivers will have=20
>> filled rx_nombuf with a value from elsewhere. This makes assignment =
of=20
>> rx_nombuf from within the driver callout redundant. Is this =
intentional?
>=20
> Yes it is strange and has always been like that.
> Why not moving the assignment before calling the driver callback?